UNST-8560 Interpolate observation station output to exact x,y location#580
Merged
UNST-8560 Interpolate observation station output to exact x,y location#580
Conversation
mihai-pricope
changed the title
arthurvd
requested changes
Feb 10, 2026
Member
arthurvd
left a comment
arthurvd
left a comment
There was a problem hiding this comment.
Hi @mihai-pricope, see my review comments.
Co-authored-by: Arthur van Dam <arthur.vandam@deltares.nl>
aslowwriter
pushed a commit
that referenced
this pull request
Feb 13, 2026
…on (#580) * copy relevant code from fm/feature/UNST-8560_nest_02 * make default Wrihis_zcor= (0 for kmx==0 , 1 for kmx > 1) * clean up code commenst and replace kmx checks with jahiszcor * init interpolation data also for cached obs points * Apply typos in comments Co-authored-by: Arthur van Dam <arthur.vandam@deltares.nl> * more cleanup * more cleanup * more cleaning * cleaning Co-authored-by: Arthur van Dam <arthur.vandam@deltares.nl> * more clean-up * partial prettify * comments --------- Co-authored-by: Arthur van Dam <arthur.vandam@deltares.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was done
Copy relevant code from branch for nesting of models, hydrodynamics for now) #462
make default Wrihis_zcor= (0 for kmx==0 , 1 for kmx > 1) (support 2d=>3d nesting)
fix initialization + cache
Evidence of the work done
<add video/figures if applicable>
Tests
<add testcase numbers if applicable, Issue number>
Documentation
<add description of changes if applicable, Issue number>
Issue link
https://issuetracker.deltares.nl/browse/UNST-8560