Update readme.md - variables block on the top #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found that if you use this to deploy several labs, you need to more quickly derive the variables used for this lab. I have moved all required variables to the top that require adjustment and from here they can be used on the management host. Hope you appreciate this change. In addition, this PR removes duplicates of $servers variable used during the lab.
reverted unintended change in L529
added timeserver to variable block
Contributor
Author
|
Hi @jaromirk do you agree with the PR and see the benefits? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that if you use this to deploy several labs, you need to more quickly derive the variables used for this lab.
I have moved all required variables to the top that require adjustment and from here they can be used on the management host. Hope you appreciate this change.
In addition, this PR removes duplicates of $servers variable used during the lab.