Extend user serializer validation to identity and permission fields#15191
Open
devGregA wants to merge 1 commit into
Open
Extend user serializer validation to identity and permission fields#15191devGregA wants to merge 1 commit into
devGregA wants to merge 1 commit into
Conversation
devGregA
force-pushed
the
devgrega/user-serializer-field-guards
branch
from
94d44e5 to
d24d456
Compare
Contributor
Author
|
/test all |
devGregA
force-pushed
the
devgrega/user-serializer-field-guards
branch
from
d24d456 to
dc5fc07
Compare
devGregA
changed the title
Extends UserSerializer.validate() to cover the email and username fields and the configuration_permissions assignment, applying the same kind of validation it already performs for the is_superuser and is_staff fields. This keeps the serializer's validation consistent across its sensitive fields. Adds unit coverage for the identity- and permission-field validation paths. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
devGregA
force-pushed
the
devgrega/user-serializer-field-guards
branch
from
dc5fc07 to
1b9f54f
Compare
github-actions
Bot
added
settings_changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends
UserSerializer.validate()to cover theemailandusernamefields and theconfiguration_permissionsassignment, applying the same kind of validation it already performs for theis_superuserandis_stafffields. This keeps the serializer's validation consistent across its sensitive fields: only superusers may change another account's identity fields or an account's configuration permissions.Users editing their own non-sensitive fields are unaffected, and superusers retain full control.
Test results
Adds
unittests/test_apiv2_user_identity_authz.pycovering the identity-field and configuration-permission validation paths.