feat: add PluggableContextTask for settings-based celery task context managers#14572
Open
valentijnscholten wants to merge 1 commit intoDefectDojo:bugfixfrom
Open
feat: add PluggableContextTask for settings-based celery task context managers#14572valentijnscholten wants to merge 1 commit intoDefectDojo:bugfixfrom
valentijnscholten wants to merge 1 commit intoDefectDojo:bugfixfrom
Conversation
… managers Add PluggableContextTask between DojoAsyncTask and PgHistoryTask that loads context managers from the CELERY_TASK_CONTEXT_MANAGERS setting. This allows plugins (e.g. Pro) to wrap all celery tasks with custom context managers without relying on celery signals (which don't fire in prefork workers). Also propagate sync kwarg from process_findings to dojo_dispatch_task in both DefaultImporter and DefaultReImporter so callers can force post_process_findings_batch to run in-process.
valentijnscholten
added
the
affects_pro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is needed for Pro.
PluggableContextTaskbetweenDojoAsyncTaskandPgHistoryTaskthat loads context managers from theCELERY_TASK_CONTEXT_MANAGERSsetting, allowing plugins to wrap all celery tasks without relying on celery signals (which don't fire in prefork workers)PgHistoryTaskto extendPluggableContextTask— no downstream changes neededsynckwarg fromprocess_findingstodojo_dispatch_taskin bothDefaultImporterandDefaultReImporterso callers can forcepost_process_findings_batchto run in-process