Add checksum verification to curl and npx installers#1903
Draft
Add checksum verification to curl and npx installers#1903
Conversation
Co-authored-by: lionello <591860+lionello@users.noreply.github.com>
Co-authored-by: lionello <591860+lionello@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix installers to verify generated checksum files
Add checksum verification to curl and npx installers
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GoReleaser generates checksum files (
defang_<version>_checksums.txt) but installers don't verify them, allowing corrupted or tampered binaries to be installed.Changes
curl installer (
src/bin/install):sha256sumorshasum -a 256npx installer (
pkgs/npm/src/clilib.ts):downloadChecksumFile()to fetch checksums from s.defang.ioverifyChecksum()using Node's crypto module for SHA256 validationBehavior:
Tests: Added unit tests covering success, failure, and error cases for npx installer.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/DefangLabs/defang/releases/latest/usr/bin/curl curl -fsSL REDACTED(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.