Copilot/add all routed experts support #293
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jinminxi104 <18713681+jinminxi104@users.noreply.github.com>
Co-authored-by: jinminxi104 <18713681+jinminxi104@users.noreply.github.com>
Co-authored-by: jinminxi104 <18713681+jinminxi104@users.noreply.github.com>
Co-authored-by: jinminxi104 <18713681+jinminxi104@users.noreply.github.com>
…ble names Co-authored-by: jinminxi104 <18713681+jinminxi104@users.noreply.github.com>
Co-authored-by: jinminxi104 <18713681+jinminxi104@users.noreply.github.com>
Co-authored-by: jinminxi104 <18713681+jinminxi104@users.noreply.github.com>
Removed output assignment from runner.capture call.
Removed make_output_buffers and get_outputs_cudagraph methods from CudaGraphMixin.
There was a problem hiding this comment.
Pull request overview
This PR adds support for "all routed experts" by refactoring CUDA graph output handling in the Ascend backend. The changes introduce a new warmup phase during graph capture and delegate output buffer management to new model methods.
Key changes:
- Added warmup execution before graph capture to create output buffers
- Refactored output handling to use
make_output_buffers()andget_outputs_cudagraph()methods - Moved the
capturingflag management inside the graph capture context
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tangzhiyi11
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.