Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 19, 2025

Rebased onto latest polygon branch (PR #99)

Successfully rebased this PR onto the latest commits from the polygon branch. Fixed issues that arose during rebase:

  • Rebased onto origin/polygon (commits c7e3318, ebaccad, 3154eac)
  • Fixed missing logger import (was removed in base branch but still used in code)
  • Updated test_init_invalid_dimensions_raises to match new transpose behavior
  • All 24 tests passing

Changes in this PR

  • Enhanced documentation for _construct_smoothing_matrix explaining edge case behavior
  • Added 3 new tests for edge cases (2-point open/closed, 3-point open polygons)
  • Fixed logger import issue introduced during rebase
  • Updated invalid dimension test to match new transpose logic from base branch

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: m-reuter <8526484+m-reuter@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP Address feedback on Polygon class implementation Document edge case behavior and add tests for smoothing small polygons Dec 19, 2025
Copilot AI requested a review from m-reuter December 19, 2025 06:55
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 54.54545% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.49%. Comparing base (44032aa) to head (8a19940).
⚠️ Report is 12 commits behind head on polygon.

Files with missing lines Patch % Lines
lapy/polygon.py 54.54% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           polygon     #100      +/-   ##
===========================================
- Coverage    44.81%   44.49%   -0.32%     
===========================================
  Files           15       15              
  Lines         2727     2744      +17     
  Branches       340      348       +8     
===========================================
- Hits          1222     1221       -1     
- Misses        1391     1401      +10     
- Partials       114      122       +8     
Flag Coverage Δ
unittests 44.49% <54.54%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@m-reuter
Copy link
Member

@copilot rebase

m-reuter and others added 5 commits December 19, 2025 07:12
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: m-reuter <8526484+m-reuter@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 19, 2025

@copilot rebase

Rebased successfully onto the latest polygon branch (commit 8a19940). Fixed a logger import issue and updated a test to match the new transpose behavior from the base branch. All 24 tests passing.

@m-reuter m-reuter marked this pull request as ready for review December 19, 2025 07:13
@m-reuter m-reuter merged commit 8dd5736 into polygon Dec 19, 2025
27 of 28 checks passed
@m-reuter m-reuter deleted the copilot/sub-pr-99 branch December 19, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants