Front-end: Added Dockerfile for application deployment #8
Open
DeekshithSN wants to merge 2 commits intoinputTestfrom
Open
Front-end: Added Dockerfile for application deployment #8DeekshithSN wants to merge 2 commits intoinputTestfrom
DeekshithSN wants to merge 2 commits intoinputTestfrom
Conversation
DeekshithSN
commented
Oct 4, 2022
| @@ -0,0 +1,11 @@ | |||
| FROM node:latest | |||
Owner
Author
There was a problem hiding this comment.
latest tag is not best practice to use, we require node 17. So we can go for node:17.9.0-slim
DeekshithSN
commented
Oct 4, 2022
| @@ -0,0 +1,11 @@ | |||
| FROM node:latest | |||
| WORKDIR /app | |||
| RUN useradd admin | |||
Owner
Author
There was a problem hiding this comment.
better to use user name same as application name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Id: AP-1