Conversation
…ere using before changed
yingchan-dev
left a comment
There was a problem hiding this comment.
In lib/dev/FakeData.ts, the URLs for names were changed from .json files to general web pages. However, if our code uses something like say, fetch().json() to parse these, it will likely crash because it will receive HTML instead of a JSON array. Also, I noticed in .env.test, if we point the http://localhost:3000 to /api/, we might run into issues where the library appends another /api/auth to it, resulting in a 404 at .../api/api/auth. However, everything else looks great! 😁
yingchan-dev
left a comment
There was a problem hiding this comment.
In lib/dev/FakeData.ts, the URLs for names were changed from .json files to general web pages. However, if our code uses something like say, fetch().json() to parse these, it will likely crash because it will receive HTML instead of a JSON array. Also, I noticed in .env.test, if we point the http://localhost:3000 to /api/, we might run into issues where the library appends another /api/auth to it, resulting in a 404 at .../api/api/auth. However, everything else looks great! 😁
|
I made a stupid temp fix for the fakedata thing, so for the time being, all of the fake users made get named after numbers, since the website we were grabbing the names from before changed and we can't do that anymore. I'll go back and change it again when we find a new website. |
No description provided.