Add live PHP API contract tests#57
Open
ejones23 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
localhost:2461.maxVotesdefaulting for MySQL, and deterministic entry ordering inget-votes.php.Verification
npm testnpm run test:api-contractnpm run buildPOST /api/new-ballot.phppayload includedmaxVotes: 1; voted and viewed expected results.positions: 2andmaxVotes: 1; voted and viewed expected results.Notes
maxVotes, so the PHP default-to-0 behavior is for omitted/empty direct API requests rather than the normal browser creation path.entries.entry_idas an auto-incrementing primary key, soORDER BY entry_id ASCreflects candidate insertion order for the existing add-entries flow.