fix(security): update Go 1.25.0 → 1.25.8, add govulncheck CI#1
Open
kiro-agent[bot] wants to merge 1 commit into
Open
fix(security): update Go 1.25.0 → 1.25.8, add govulncheck CI#1kiro-agent[bot] wants to merge 1 commit into
kiro-agent[bot] wants to merge 1 commit into
Conversation
…ities Fixes the following Go standard library vulnerabilities that affect Mole's code paths: - GO-2026-4602: os.File.Readdir / filepath.WalkDir can escape from a Root (used in cmd/status/metrics_cpu.go, cmd/status/metrics_disk.go) - GO-2026-4601: incorrect parsing of IPv6 host literals in net/url (used in cmd/status/metrics_network.go via url.Parse) - GO-2025-4010: insufficient validation of bracketed IPv6 hostnames in net/url (same code path as above) Also adds a govulncheck CI job to catch future stdlib and dependency vulnerabilities automatically on every PR. Co-authored-by: DavidDelOJo <101717724+DavidDelOjo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created by @kiro-agent on behalf of @DavidDelOjo 👻
Comment with /kiro fix to address specific feedback or /kiro all to address everything.
Learn about Kiro autonomous agent
Summary
Updates Go minimum version from 1.25.0 to 1.25.8 to fix 3 standard library vulnerabilities that affect Mole's code paths, and adds continuous vulnerability scanning to CI.
Vulnerabilities Fixed
os(FileInfo escape from Root)cmd/status/metrics_cpu.go,cmd/status/metrics_disk.gouseReaddir/WalkDirnet/url(IPv6 host literal parsing)cmd/status/metrics_network.gocallsurl.Parsenet/url(bracketed IPv6 validation)Changes
go.mod: Bumpgo 1.25.0→go 1.25.8go.sum: Updated bygo mod tidy.github/workflows/test.yml: Newgovulncheckjob that runsgolang.org/x/vuln/cmd/govulncheckon every PR to catch future vulnerabilities automaticallyTesting
go mod tidy✓go build ./...✓govulncheck ./...reports 0 reachable vulnerabilities after upgradeNotes for upstream contribution
This PR is prepared following CONTRIBUTING.md guidelines. To contribute upstream to
tw93/Mole, open a cross-fork PR fromDavidDelOjo/Mole:fix/go-stdlib-vulnerabilities→tw93/Mole:main.