Skip to content

fix(security): update Go 1.25.0 → 1.25.8, add govulncheck CI#1

Open
kiro-agent[bot] wants to merge 1 commit into
mainfrom
fix/go-stdlib-vulnerabilities
Open

fix(security): update Go 1.25.0 → 1.25.8, add govulncheck CI#1
kiro-agent[bot] wants to merge 1 commit into
mainfrom
fix/go-stdlib-vulnerabilities

Conversation

@kiro-agent

@kiro-agent kiro-agent Bot commented Jun 1, 2026

Copy link
Copy Markdown

This pull request was created by @kiro-agent on behalf of @DavidDelOjo 👻

Comment with /kiro fix to address specific feedback or /kiro all to address everything.
Learn about Kiro autonomous agent


Summary

Updates Go minimum version from 1.25.0 to 1.25.8 to fix 3 standard library vulnerabilities that affect Mole's code paths, and adds continuous vulnerability scanning to CI.

Vulnerabilities Fixed

ID Package Impact in Mole Fixed in
GO-2026-4602 os (FileInfo escape from Root) cmd/status/metrics_cpu.go, cmd/status/metrics_disk.go use Readdir/WalkDir go1.25.8
GO-2026-4601 net/url (IPv6 host literal parsing) cmd/status/metrics_network.go calls url.Parse go1.25.8
GO-2025-4010 net/url (bracketed IPv6 validation) Same code path as above go1.25.2

Changes

  • go.mod: Bump go 1.25.0go 1.25.8
  • go.sum: Updated by go mod tidy
  • .github/workflows/test.yml: New govulncheck job that runs golang.org/x/vuln/cmd/govulncheck on every PR to catch future vulnerabilities automatically

Testing

  • go mod tidy
  • go build ./...
  • govulncheck ./... reports 0 reachable vulnerabilities after upgrade

Notes for upstream contribution

This PR is prepared following CONTRIBUTING.md guidelines. To contribute upstream to tw93/Mole, open a cross-fork PR from DavidDelOjo/Mole:fix/go-stdlib-vulnerabilitiestw93/Mole:main.

…ities

Fixes the following Go standard library vulnerabilities that affect
Mole's code paths:

- GO-2026-4602: os.File.Readdir / filepath.WalkDir can escape from a
  Root (used in cmd/status/metrics_cpu.go, cmd/status/metrics_disk.go)
- GO-2026-4601: incorrect parsing of IPv6 host literals in net/url
  (used in cmd/status/metrics_network.go via url.Parse)
- GO-2025-4010: insufficient validation of bracketed IPv6 hostnames
  in net/url (same code path as above)

Also adds a govulncheck CI job to catch future stdlib and dependency
vulnerabilities automatically on every PR.

Co-authored-by: DavidDelOJo <101717724+DavidDelOjo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant