Rewrapped function with C++14 and repackaged with VS2022#3
Open
GsoyG wants to merge 30 commits intoDavidAnson:masterfrom
Open
Rewrapped function with C++14 and repackaged with VS2022#3GsoyG wants to merge 30 commits intoDavidAnson:masterfrom
GsoyG wants to merge 30 commits intoDavidAnson:masterfrom
Conversation
GsoyG
commented
Nov 25, 2023
- Encapsulate the main functions into the DHCPServer class and the message structure into the DHCPMessage class.
- Split the output into main.cpp and replace the original error output with exceptions.
- Replaced the original macro definition with static member functions and constant expressions.
- Put the else judgment of if in front to simplify the if hierarchy.
- Removed LocalFree check.
Owner
|
This is very interesting, but I'm not in a place to review or test changes to this project. Sorry! Looking at how much you've invested, maybe you would like to maintain a fork of the project? |
Author
|
Thank you very much for your reply. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.