fix(explore): align the expand chevron to the top band#132
Merged
Conversation
The collapse chevron sits in the top 28px header band, but the expand chevron floated at the rail's vertical centre — inconsistent and confusing. Top-align the expand chevron so collapse/expand share the same placement. The whole rail stays tappable (the InkWell still fills the region); only the icon's position moves into the top band. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up UX fix. The collapse chevron lives in the top 28px header band, but the expand chevron floated at the rail's vertical centre — inconsistent placement. Top-align the expand chevron so collapse and expand share the same position.
The whole collapsed rail remains tappable (the
InkWellstill fills the region, per #131); only the chevron icon moves into the top band.Test plan
test/crm/both_panes_collapse_test.dart(no-mock, real fixture):collapse both panes, then both expand chevrons work(taps the rail centre — works only because the full rail is the hit target, since the icon is now at the top);a tap anywhere in the collapsed rail re-expands it— now taps low in the rail (75% down), well away from the top chevron, so it genuinely exercises the full-rail target.flutter analyzeclean; full suite green.🤖 Generated with Claude Code