fix(demo): disable the metrics listener in verify-demo.sh#129
Merged
Conversation
After #120 split metrics onto a dedicated listener (default :9090), verify-demo.sh — which never set ESCUREL_OBSERVABILITY_METRICS_LISTEN — started binding :9090, clashing with a co-running gateway or a parallel demo run. The demo doesn't scrape metrics, so set the var empty to disable the listener entirely (verified: empty → no :9090 bind, server still healthy). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #120. That PR moved
/metricsonto a dedicated listener(default
:9090) and pinned the port inbinary_boots.rs, but missedscripts/verify-demo.sh— which never setESCUREL_OBSERVABILITY_METRICS_LISTEN, so the demo server now binds thedefault
:9090and collides with a co-running gateway or a paralleldemo run.
The demo doesn't scrape metrics, so this sets the var empty to disable
the dedicated listener entirely.
Test plan
Booted a server with
ESCUREL_OBSERVABILITY_METRICS_LISTEN="":healthy on its HTTP port, no
:9090bind,/metrics404 on themain port (unchanged). Surfaced while running
verify-demo.shend-to-end during the spec-conformance pass.
🤖 Generated with Claude Code