test(explore): event-pane re-open via real skill navigation#128
Merged
Conversation
Adds a faithful regression test for the skill-page event-pane chevron (fixed in #126): a real fixture + an actual navigation to a skill, so `currentPage` resolves async and `isSkill` flips through the real provider machinery (including the reset listener) before the chevron is tapped — closer to the live flow than the existing static-override test, and a guard against flicker-class regressions in the collapse state. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up coverage for the skill-page event-pane chevron fix (#126). Adds a regression test that mirrors the live flow more faithfully than the existing static-override test: a real fixture, an actual navigation to a skill (so
currentPageresolves async andisSkillflips through the real provider machinery, including the reset listener), then a pointer tap on the expand chevron.This guards against flicker-class regressions where a
currentPagere-evaluation could snap the user's explicit collapse choice back to the skill default.Test plan
test/crm/crm_workspace_test.dart→ newnavigate to a skill, then the chevron re-opens the event pane (real nav).flutter analyzeclean; full suite green (95 tests).🤖 Generated with Claude Code