Conversation
Updates: - cryptography: 46.0.5 → 46.0.7 (security: CVE-2026-39892, CVE-2026-34073) - deepdiff: <9.0 → <10.0 (upper bound relaxation) - pygments: 2.19.2 → 2.20.0 - @amplitude/unified: 1.0.5 → 1.0.15 - @amplitude/analytics-core: ^2.44.0 → ^2.44.1 - @biomejs/biome: 2.4.9 → 2.4.10 - @codemirror/view: ^6.40.0 → ^6.41.0 - @next/third-parties: 16.2.1 → 16.2.2 - @playwright/test: ^1.58.2 → ^1.59.1 - @sentry/nextjs: ^10.46.0 → ^10.47.0 - @sentry/react: ^10.46.0 → ^10.47.0 - @storybook/*: ^10.3.3 → ^10.3.4 - @tanstack/react-query: 5.95.2 → 5.96.1 - @tsdown/css: ^0.21.5 → ^0.21.7 - @xyflow/react: ^12.10.1 → ^12.10.2 - baseline-browser-mapping: ^2.10.11 → ^2.10.13 - lodash: ^4.17.23 → ^4.18.1 - next: 16.2.1 → 16.2.2 - playwright: ^1.58.2 → ^1.59.1 - read-excel-file: ^7.0.3 → ^8.0.3 (major; updated test for v8 API) - tsdown: ^0.21.5 → ^0.21.7 - write-excel-file: ^3.0.6 → ^3.0.8 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jared Scott <jared.scott@datarecce.io>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Consolidates multiple Dependabot updates (Python + JS) into one set of dependency bumps, with a small test adjustment to accommodate the read-excel-file v8 API shape.
Changes:
- Python: widen
deepdiffconstraint to allow<10.0and update lockfile accordingly. - Frontend: bump multiple JS deps (Next.js, Sentry, lodash, Playwright/Storybook, etc.) and refresh
pnpm-lock.yaml. - UI tests: update Excel blob parsing test helper for the updated
read-excel-filereturn format.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Updates locked dependency metadata to reflect the widened deepdiff constraint. |
pyproject.toml |
Widens deepdiff requirement from <9.0 to <10.0. |
js/pnpm-lock.yaml |
Updates the JS dependency graph/lock to the consolidated set of bumps. |
js/packages/ui/src/utils/csv/__tests__/excel.test.ts |
Adjusts Excel parsing test helper for read-excel-file v8 sheet return shape. |
js/packages/ui/package.json |
Bumps dev-only tooling deps (and read-excel-file) used in the UI workspace. |
js/packages/storybook/package.json |
Bumps Storybook/Playwright dev dependencies. |
js/package.json |
Bumps root app dependencies and pnpm.overrides to align the monorepo on newer versions. |
| "minimatch@>=9.0.0 <9.0.7": ">=9.0.7", | ||
| "minimatch@>=10.0.0 <10.2.3": ">=10.2.3", | ||
| "rollup@>=4.0.0 <4.59.0": ">=4.59.0", | ||
| "@amplitude/unified": "1.0.5" | ||
| "@amplitude/unified": "1.0.15" | ||
| }, |
There was a problem hiding this comment.
pnpm.overrides forces @amplitude/unified to 1.0.15 across the monorepo, but @datarecce/ui declares a pinned dependency of @amplitude/unified at 1.0.1 (and the dependency contract doc calls it “Pinned. Exact version required”). This means CI/dev is no longer exercising the version that consumers of the published @datarecce/ui package will actually install, which can hide compatibility issues. Consider either updating js/packages/ui/package.json (and DEPENDENCIES.md) to the new pinned version, or removing the override / aligning root versions so the tested version matches the published contract.
Updated Review — PR #1288SummaryDependency consolidation PR. All checks pass after proper
Findings[Info]
|
| Check | Result |
|---|---|
| Python tests (1037) | PASS |
| Python lint (flake8) | PASS |
| Frontend lint (Biome) | PASS |
| Frontend build (Next.js) | PASS |
| Frontend type check | PASS |
| Frontend tests (3644) | PASS (all 17 Excel tests included) |
@datarecce/ui dep floors |
Correct — not bumped (changes are devDependencies only) |
deepdiff <10.0 |
Safe — only uses DeepDiff() with ignore_order=True, no removed APIs |
pnpm.overrides consistency |
Correct — all shared packages properly overridden |
Verdict
Approved — All dependency updates verified. Tests, lint, type check, and build all pass. The read-excel-file v8 API adaptation is correct. Python deps (deepdiff, cryptography, pygments) are safe upgrades.
gcko
left a comment
There was a problem hiding this comment.
Claude Code Review: Critical issues found — read-excel-file v8 migration breaks 14 tests and TypeScript type check. See review comment for details.
Summary
Consolidates the following Dependabot PRs into a single tested update:
Changes
Notes
{ sheet, data }[]instead of flat row arrays. Updatedexcel.test.tsto use the new API.Test plan
Generated with Claude Code