feat(lineage): add Body Changes view mode to filter config-only changes#1268
Draft
feat(lineage): add Body Changes view mode to filter config-only changes#1268
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Add a new "Body Changes" mode to the lineage view Mode dropdown that uses state:modified.body + state:modified.macros + state:modified.contract selectors. This filters out config-only YAML changes (tags, descriptions, deprecation dates, etc.) while keeping data-impacting changes visible. The existing "Changed Models" and "All" modes remain unchanged. Resolves DRC-3047 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: even-wei <evenwei@infuseai.io>
- Add missing body_changes to LineageView.tsx and LineageDiffView.tsx types - Handle body_changes in Cloud LineageView node filtering (was falling through to "all") - Update stale comments in run.ts, LineageViewTopBar docstring, and 3 test files - Add Body Changes radio to dropdown assertion in existing test - Add interaction test for switching to body_changes mode Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: even-wei <evenwei@infuseai.io>
even-wei
force-pushed
the
feature/drc-3047-body-changes-mode
branch
from
062059a to
9fbdd18
Compare
Cover the body_changes branch in select_nodes to fix patch coverage. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: even-wei <evenwei@infuseai.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
What type of PR is this?
Feature
What this PR does / why we need it:
Adds a new "Body Changes" mode to the lineage view Mode dropdown. This mode uses
state:modified.body,state:modified.macros, andstate:modified.contractselectors to filter out config-only YAML changes (tags, descriptions, deprecation dates, warehouse, materialization, etc.) while keeping data-impacting changes visible.This reduces noise for users whose PRs touch YAML config without changing SQL logic — a pain point raised by customers (see Slack thread in #customer-super).
Which issue(s) this PR fixes:
Resolves DRC-3047
Special notes for your reviewer:
1+state:modified+) and "All" modes remain unchangedchanged_modelsis still the default for UI and MCPrecce summarycommand is not changed in this PR; it already excludes config-only changes via checksum comparison. A follow-up issue can add full selector parity if neededimpact_analysistool already uses this same selector pattern (state:modified.body+ state:modified.macros+ state:modified.contract+)Does this PR introduce a user-facing change?:
Yes — new "Body Changes" option in the lineage view Mode dropdown that filters to only SQL body, macro, and contract changes.
🤖 Generated with Claude Code