-
Notifications
You must be signed in to change notification settings - Fork 1
refactor(plugin): rename recce-dev to recce, add recce-dev for internal tooling #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e9db57b
refactor: rename recce-dev plugin to recce
iamcxa 080f21a
feat: add recce-dev plugin for internal MCP E2E validation
iamcxa 29220f4
feat(08-01): create esbuild bundle pipeline for plugin distribution
iamcxa 8c69c04
feat(08-01): update smoke test for renamed plugin and bundle distribu…
iamcxa 05cf562
fix: cross-plugin path resolution and skill quality improvements
iamcxa e5749f5
docs: add resolve-recce-root.sh to README components
iamcxa 7505083
feat(09-01): fix esbuild devDep and update build-bundle.sh path
iamcxa a125f63
feat(09-01): add pre-push hook, install script, and local freshness c…
iamcxa 4b17d8d
feat(09-02): create GitHub Actions bundle-freshness CI workflow
iamcxa 93f8afa
docs: update root README to cover all three plugins
iamcxa 1776a01
fix: address review feedback — docs accuracy and shell safety
iamcxa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| # Validates that committed bundles match what would be produced from current source. | ||
| # Fails PRs where packages/recce-docs-mcp/src/** changed but dist/cli.js was not rebuilt. | ||
| # | ||
| # Pattern: check-dist (canonical from actions/typescript-action) | ||
| # Ref: https://github.com/actions/typescript-action/blob/main/.github/workflows/check-dist.yml | ||
| name: Check Bundle Freshness | ||
|
|
||
| on: | ||
| push: | ||
| paths: | ||
| - 'packages/recce-docs-mcp/src/**' | ||
| pull_request: | ||
| paths: | ||
| - 'packages/recce-docs-mcp/src/**' | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| bundle-freshness: | ||
| name: bundle-freshness | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20' | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci --prefix packages/recce-docs-mcp | ||
|
|
||
| - name: Rebuild bundle | ||
| run: bash packages/recce-docs-mcp/scripts/build-bundle.sh | ||
|
|
||
| - name: Check bundle freshness | ||
| id: diff | ||
| run: | | ||
| DIFF_LINES=$(git diff --ignore-space-at-eol --text -- "plugins/*/servers/recce-docs-mcp/dist/cli.js" | wc -l) | ||
| if [ "$DIFF_LINES" -gt "0" ]; then | ||
| echo "ERROR: bundle is stale after rebuild. Did you forget to commit the updated bundle?" | ||
| echo "" | ||
| echo "Rebuild with:" | ||
| echo " cd packages/recce-docs-mcp && npm run build:bundle" | ||
| echo " git add plugins/recce/servers/recce-docs-mcp/dist/cli.js" | ||
| echo " git add plugins/recce-quickstart/servers/recce-docs-mcp/dist/cli.js" | ||
| echo " git commit -m 'chore: rebuild bundle'" | ||
| git diff --stat -- "plugins/*/servers/recce-docs-mcp/dist/cli.js" | ||
| exit 1 | ||
| fi | ||
| echo "Bundle is fresh." | ||
|
|
||
| - name: Upload expected bundle on failure | ||
| if: failure() && steps.diff.outcome == 'failure' | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: expected-bundle | ||
| path: | | ||
| plugins/recce/servers/recce-docs-mcp/dist/cli.js | ||
| plugins/recce-quickstart/servers/recce-docs-mcp/dist/cli.js | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| node_modules/ | ||
| cache/*.json | ||
| cache/pages/ | ||
| dist-bundle/ |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid observation. Build script changes are rare and the current filter covers the primary case (src changes). Adding build-bundle.sh and package.json to the paths filter is a reasonable improvement — will address as a follow-up.