Add compatibility layer between legacy units and new units#2165
Open
shangyian wants to merge 6 commits into
Open
Add compatibility layer between legacy units and new units#2165shangyian wants to merge 6 commits into
shangyian wants to merge 6 commits into
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
shangyian
force-pushed
the
units-compat
branch
2 times, most recently
from
44d2169 to
fea68d1
Compare
…nto one canonical form
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change bridges the structured new unit field on columns (added in #2149) with the legacy metric metadata unit enum so that input + output surfaces and storage writes stay consistent. Users should not need to migrate any YAML, and API consumers reading the legacy field can continue to do so.
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan