Fix duplicate CTEs in SQL build v2 #1642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
shangyian
force-pushed
the
fix-duplicate-ctes
branch
from
89b79df to
eaac1b6
Compare
shangyian
force-pushed
the
fix-duplicate-ctes
branch
from
eaac1b6 to
06b016c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the duplicate CTEs issue in generated SQL (using build v2). The duplicate CTEs were caused by two functions in
build_v2.pythat were adding CTEs to queries without checking if a CTE with the same name already existed:convert_to_cteandbuild_ast.With this fix, both functions now deduplicate CTEs by their name before adding them.
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan