Skip to content

Conversation

@festelo
Copy link
Collaborator

@festelo festelo commented May 11, 2021

No description provided.

Copy link
Contributor

@ltfschoen ltfschoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've proposed some changes in branch 'luke/ilya/MMD-1023'.

maybe change the order of the parameters like returnAddress, but this will impact calls from DataDash, so may cause unnecessary extra work.

and we don't need returnAddress for signalling, as they aren't locking any tokens. so it's only necessary for locking

ideally we could update the tests to check it locks the tokens and returns them to the returnAddress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants