Auto-activate nodejs manifest tests#7261
Conversation
This commit was created from the local commit with hash 9fec56018564496423c47a03f5b4ed950c843711.
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f27ec03418
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| express5: '>=6.0.0' | ||
| express4: '>=6.0.0' | ||
| express4-typescript: '>=6.0.0' | ||
| fastify: '>=6.0.0' | ||
| uds-express4: '>=6.0.0' |
There was a problem hiding this comment.
When Node.js CI is running the 6.0 prerelease, these new >=6.0.0 thresholds do not match 6.0.0-pre because prereleases sort before the final 6.0.0; this same manifest defines ref_6_0_0 as >=6.0.0-pre on line 102 and uses it elsewhere. As written, the newly activated tests with >=6.0.0/v6.0.0 and the corresponding <6.0.0 skips remain xfailed on 6.0.0-pre runs and only flip after the final release, so use *ref_6_0_0/>=6.0.0-pre and matching prerelease-aware lower bounds if the intent is to activate on the current Node 6 line.
Useful? React with 👍 / 👎.
|
Automated activation of easy-win tests for nodejs
View nightly workflow run