Skip to content

fix(nodejs): fix ssi tests after engines bump #7258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pabloerhard wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −7
Draft

fix(nodejs): fix ssi tests after engines bump #7258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions tests/docker_ssi/test_docker_ssi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ def setup_install_supported_runtime(self):
@irrelevant(context.library == "python" and context.installed_language_runtime < "3.8.0")
@irrelevant(context.library == "java" and context.installed_language_runtime < "1.8.0_0")
@irrelevant(context.library == "php" and context.installed_language_runtime < "7.0")
@irrelevant(context.library == "nodejs" and context.installed_language_runtime < "17.0")
@irrelevant(context.library >= "nodejs@6.0.0-0" and context.installed_language_runtime < "22.0")
@irrelevant(context.library < "nodejs@6.0.0-0" and context.installed_language_runtime < "17.0")
@irrelevant(context.library >= "python@4.0.0rc1" and context.installed_language_runtime < "3.9.0")
@irrelevant(context.library == "ruby" and context.installed_language_runtime < "2.6.0")
def test_install_supported_runtime(self):
Expand Down Expand Up @@ -77,7 +78,8 @@ def test_install_weblog_running(self):
)
@irrelevant(context.library == "java" and context.installed_language_runtime < "1.8.0_0")
@irrelevant(context.library == "php" and context.installed_language_runtime < "7.0")
@irrelevant(context.library == "nodejs" and context.installed_language_runtime < "17.0")
@irrelevant(context.library >= "nodejs@6.0.0-0" and context.installed_language_runtime < "22.0")
@irrelevant(context.library < "nodejs@6.0.0-0" and context.installed_language_runtime < "17.0")
@irrelevant(context.library >= "python@4.0.0rc1" and context.installed_language_runtime < "3.9.0")
@irrelevant(context.library == "ruby" and context.installed_language_runtime < "2.6.0")
def test_telemetry(self):
Expand Down Expand Up @@ -106,7 +108,8 @@ def test_telemetry(self):
@irrelevant(context.library == "php" and context.installed_language_runtime >= "7.0")
@bug(context.library == "nodejs" and context.installed_language_runtime < "12.17.0", reason="INPLAT-252")
@bug(context.library == "java" and context.installed_language_runtime == "1.7.0-201", reason="INPLAT-427")
@irrelevant(context.library == "nodejs" and context.installed_language_runtime >= "17.0")
@irrelevant(context.library >= "nodejs@6.0.0-0" and context.installed_language_runtime >= "22.0")
@irrelevant(context.library < "nodejs@6.0.0-0" and context.installed_language_runtime >= "17.0")
@irrelevant(context.library == "dotnet" and context.installed_language_runtime >= "6.0.0")
@irrelevant(context.library == "ruby" and context.installed_language_runtime >= "2.6.0")
def test_telemetry_abort(self):
Expand Down Expand Up @@ -145,7 +148,8 @@ def setup_instrumentation_source_ssi(self):
@irrelevant(context.library == "python" and context.installed_language_runtime < "3.9.0")
@irrelevant(context.library == "java" and context.installed_language_runtime < "1.8.0_0")
@irrelevant(context.library == "php" and context.installed_language_runtime < "7.1")
@irrelevant(context.library == "nodejs" and context.installed_language_runtime < "17.0")
@irrelevant(context.library >= "nodejs@6.0.0-0" and context.installed_language_runtime < "22.0")
@irrelevant(context.library < "nodejs@6.0.0-0" and context.installed_language_runtime < "17.0")
@irrelevant(context.library >= "python@4.0.0.dev" and context.installed_language_runtime < "3.9.0")
@irrelevant(context.library < "python@4.0.0.dev" and context.installed_language_runtime < "3.8.0")
@irrelevant(context.library == "ruby" and context.installed_language_runtime < "2.6.0")
Expand All @@ -168,7 +172,8 @@ def setup_injection_metadata(self):
@irrelevant(context.library == "python" and context.installed_language_runtime < "3.8.0")
@irrelevant(context.library == "java" and context.installed_language_runtime < "1.8.0_0")
@irrelevant(context.library == "php" and context.installed_language_runtime < "7.1")
@irrelevant(context.library == "nodejs" and context.installed_language_runtime < "17.0")
@irrelevant(context.library >= "nodejs@6.0.0-0" and context.installed_language_runtime < "22.0")
@irrelevant(context.library < "nodejs@6.0.0-0" and context.installed_language_runtime < "17.0")
@irrelevant(context.library >= "python@4.0.0rc1" and context.installed_language_runtime < "3.9.0")
def test_injection_metadata(self):
logger.info("Testing injection result variables")
Expand Down
3 changes: 2 additions & 1 deletion tests/docker_ssi/test_docker_ssi_appsec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ def setup_telemetry_source_ssi(self):

@irrelevant(context.library == "java" and context.installed_language_runtime < "1.8.0_0")
@irrelevant(context.library == "php" and context.installed_language_runtime < "7.1")
@irrelevant(context.library == "nodejs" and context.installed_language_runtime < "17.0")
@irrelevant(context.library >= "nodejs@6.0.0-0" and context.installed_language_runtime < "22.0")
@irrelevant(context.library < "nodejs@6.0.0-0" and context.installed_language_runtime < "17.0")
@irrelevant(context.library >= "python@4.0.0.dev" and context.installed_language_runtime < "3.9.0")
@irrelevant(context.library < "python@4.0.0.dev" and context.installed_language_runtime < "3.8.0")
@irrelevant(context.library == "ruby" and context.installed_language_runtime < "2.6.0", reason="Ruby 2.6+ required")
Expand Down
3 changes: 2 additions & 1 deletion tests/docker_ssi/test_docker_ssi_crash.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ def setup_crash(self):

@features.ssi_crashtracking
@irrelevant(context.library == "python" and context.installed_language_runtime < "3.7.0")
@irrelevant(context.library == "nodejs" and context.installed_language_runtime < "17.0")
@irrelevant(context.library >= "nodejs@6.0.0-0" and context.installed_language_runtime < "22.0")
@irrelevant(context.library < "nodejs@6.0.0-0" and context.installed_language_runtime < "17.0")
@irrelevant(context.library == "ruby" and context.installed_language_runtime < "2.6.0")
def test_crash(self):
"""Validate that a crash report is generated when the application crashes"""
Expand Down
Loading