Auto-activate rust easy wins for apm-sdk-capabilities#7242
Auto-activate rust easy wins for apm-sdk-capabilities#7242dd-octo-sts[bot] wants to merge 1 commit into
Conversation
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7f891f63d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| component_version: <0.4.1-dev+83c985c | ||
| tests/parametric/test_otel_logs.py::Test_FR13_Scope_Fields::test_scope_schema_url_field: missing_feature (OpenTelemetry Rust SDK limitation - schema_url not exported by opentelemetry-otlp) | ||
| tests/parametric/test_otel_logs.py::Test_FR13_Scope_Fields::test_scope_version_field: missing_feature (OpenTelemetry Rust SDK limitation - scope version not exported by opentelemetry-otlp) | ||
| tests/parametric/test_otel_logs.py::Test_FR13_Scope_Fields::test_scope_version_field: # TODO: a lower version might be supported | ||
| - declaration: missing_feature (OpenTelemetry Rust SDK limitation - scope version not exported by opentelemetry-otlp) | ||
| component_version: <0.4.1-dev+83c985c |
There was a problem hiding this comment.
When Rust is tested from a git checkout, utils/build/docker/rust/install_ddtrace.sh builds versions as 0.4.1-dev+<short-sha>, but the <0.4.1-dev+83c985c range is a SemVer comparison over build metadata/a git SHA, not a chronological commit boundary. For any dd-trace-rs branch before the fix whose SHA sorts after 83c985c (or a later one sorting before it), these two tests will be incorrectly activated or skipped, so this should stay disabled until a real release/version boundary rather than using the commit hash in the range.
Useful? React with 👍 / 👎.
Automated activation of easy-win tests for
rustowned byapm-sdk-capabilitiesView nightly workflow run