Skip to content

Conversation

@kakkoyun
Copy link
Member

@kakkoyun kakkoyun commented Feb 11, 2026

Go 1.26 has been released, so bump the minimum supported Go version
to 1.25 across all Go Docker images and module files.

Signed-off-by: Kemal Akkoyun kemal.akkoyun@datadoghq.com

Motivation

xref: DataDog/dd-trace-go#4403

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

Go 1.26 has been released, so bump the minimum supported Go version
to 1.25 across all Go Docker images and module files.

Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

utils/build/docker/golang/app/go.mod                                    @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/app/net-http-orchestrion/go.mod               @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/chi.Dockerfile                                @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/echo.Dockerfile                               @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/gin.Dockerfile                                @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/gqlgen.Dockerfile                             @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/graph-gophers.Dockerfile                      @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/graphql-go.Dockerfile                         @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/net-http-orchestrion.Dockerfile               @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/net-http.Dockerfile                           @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/parametric/Dockerfile                         @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/parametric/go.mod                             @DataDog/dd-trace-go-guild @DataDog/system-tests-core
utils/build/docker/golang/uds-echo.Dockerfile                           @DataDog/dd-trace-go-guild @DataDog/system-tests-core

Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

@kakkoyun
Copy link
Member Author

An unrelated PHP test fails:

Run actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093
Downloading single artifact
Error: Unable to download artifact(s): Failed to ListArtifacts: Received non-retryable error: Failed request: (403) Forbidden: Error from intermediary with HTTP status code 403 "Forbidden"

https://github.com/DataDog/system-tests/actions/runs/21911275252/job/63269677667?pr=6277

Is it a flake? What's the course of action here?

@datadog-official
Copy link

datadog-official bot commented Feb 11, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

❄️ 3 New flaky tests detected

tests.debugger.test_debugger_capture_expressions.Test_Debugger_Method_Capture_Expressions.test_log_method_capture_expressions[spring-boot-wildfly] from system_tests_suite (Datadog) (Fix with Cursor)
AssertionError: assert 'Snapshot was not received' is None
 +  where 'Snapshot was not received' = <built-in method join of str object at 0x7fac8f22aa60>(['Snapshot was not received'])
 +    where <built-in method join of str object at 0x7fac8f22aa60> = '\n'.join
 +    and   ['Snapshot was not received'] = <tests.debugger.test_debugger_capture_expressions.Test_Debugger_Method_Capture_Expressions object at 0x7fac85171bb0>.setup_failures

self = <tests.debugger.test_debugger_capture_expressions.Test_Debugger_Method_Capture_Expressions object at 0x7fac85171bb0>

    def test_log_method_capture_expressions(self):
>       self._assert()

...
tests.parametric.test_crashtracking.Test_Crashtracking.test_report_crash[library_env0, parametric-php] from system_tests_suite (Datadog) (Fix with Cursor)
KeyError: 0

self = <tests.parametric.test_crashtracking.Test_Crashtracking object at 0x7f45fb5a9c70>
test_agent = <utils.docker_fixtures._test_agent.TestAgentAPI object at 0x7f45c6833a40>
test_library = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7f45c6ad95e0>

    @pytest.mark.parametrize("library_env", [{"DD_CRASHTRACKING_ENABLED": "true"}])
    def test_report_crash(self, test_agent: TestAgentAPI, test_library: APMLibrary):
        test_library.crash()
    
...
tests.parametric.test_dynamic_configuration.TestDynamicConfigSamplingRules.test_remote_sampling_rules_retention[library_env0, parametric-python] from system_tests_suite (Datadog) (Fix with Cursor)
assert 1.0 == 0.1 ± 1.0e-07
  comparison failed
  Obtained: 1.0
  Expected: 0.1 ± 1.0e-07

self = <tests.parametric.test_dynamic_configuration.TestDynamicConfigSamplingRules object at 0x7f7d1ba4ef30>
test_agent = <utils.docker_fixtures._test_agent.TestAgentAPI object at 0x7f7ce6c4aa80>
test_library = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7f7ce6c48d40>

    @parametrize("library_env", [{**DEFAULT_ENVVARS}])
...

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9e1328a | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@kakkoyun kakkoyun marked this pull request as draft February 11, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants