-
Notifications
You must be signed in to change notification settings - Fork 14
chore(otel): add logs endpoints to rust parametric app #6137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 0fe120f | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
# What does this PR do? Adds OpenTelemetry Logs API support to the `datadog-opentelemetry` crate, mirroring the existing metrics implementation. # Motivation - Provides a consistent API for logs export matching the metrics API (`logs()` mirrors `metrics()`) - Enables OTLP-based logs export via gRPC and HTTP/protobuf protocols - Follows the same patterns and conventions as the metrics implementation for maintainability # Additional Notes - New feature flags: `logs-grpc` and `logs-http` (mirroring `metrics-grpc` and `metrics-http`) - Configuration via standard OpenTelemetry environment variables (`DD_LOGS_OTEL_ENABLED`, `OTEL_EXPORTER_OTLP_LOGS_*`) - Returns no-op logger provider on errors to prevent application crashes - Note: OpenTelemetry 0.31.0 doesn't have a global logger provider setter, so users must manage the logger provider instance - Testing: DataDog/system-tests#6137 --------- Co-authored-by: paullegranddc <82819397+paullegranddc@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4923a1255a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
nccatoni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (@DataDog/system-tests-core) but you should get a review from someone familiar the rust weblog
Motivation
Changes
Support:
Update tests to be compatible with logs implementation
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present