Skip to content

Conversation

@mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Jan 28, 2026

Motivation

  • Adds endpoints to rust parametric to test otel logs support.
  • Makes minor updates tests to be compatible with the rust implementation

Changes

Support:

  • /otel/logger/create
  • /otel/logger/write

Update tests to be compatible with logs implementation

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026

CODEOWNERS have been resolved as:

manifests/rust.yml                                                      @DataDog/apm-rust
tests/parametric/test_otel_logs.py                                      @DataDog/system-tests-core @DataDog/apm-sdk-capabilities
utils/build/docker/rust/parametric/Cargo.lock                           @DataDog/apm-rust @DataDog/system-tests-core
utils/build/docker/rust/parametric/Cargo.toml                           @DataDog/apm-rust @DataDog/system-tests-core
utils/build/docker/rust/parametric/src/main.rs                          @DataDog/apm-rust @DataDog/system-tests-core
utils/build/docker/rust/parametric/src/opentelemetry/dto.rs             @DataDog/apm-rust @DataDog/system-tests-core
utils/build/docker/rust/parametric/src/opentelemetry/mod.rs             @DataDog/apm-rust @DataDog/system-tests-core
utils/docker_fixtures/_test_clients/_test_client_parametric.py          @DataDog/system-tests-core
utils/docker_fixtures/spec/trace.py                                     @DataDog/system-tests-core

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 30, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0fe120f | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@mabdinur mabdinur changed the title Munir/add rust parametric endpoints chore(otel): add logs endpoints to rust parametric app Feb 1, 2026
mabdinur added a commit to DataDog/dd-trace-rs that referenced this pull request Feb 9, 2026
# What does this PR do?

Adds OpenTelemetry Logs API support to the `datadog-opentelemetry`
crate, mirroring the existing metrics implementation.

# Motivation

- Provides a consistent API for logs export matching the metrics API
(`logs()` mirrors `metrics()`)
- Enables OTLP-based logs export via gRPC and HTTP/protobuf protocols
- Follows the same patterns and conventions as the metrics
implementation for maintainability

# Additional Notes

- New feature flags: `logs-grpc` and `logs-http` (mirroring
`metrics-grpc` and `metrics-http`)
- Configuration via standard OpenTelemetry environment variables
(`DD_LOGS_OTEL_ENABLED`, `OTEL_EXPORTER_OTLP_LOGS_*`)
- Returns no-op logger provider on errors to prevent application crashes
- Note: OpenTelemetry 0.31.0 doesn't have a global logger provider
setter, so users must manage the logger provider instance
- Testing: DataDog/system-tests#6137

---------

Co-authored-by: paullegranddc <82819397+paullegranddc@users.noreply.github.com>
@mabdinur mabdinur marked this pull request as ready for review February 9, 2026 15:52
@mabdinur mabdinur requested review from a team as code owners February 9, 2026 15:52
@mabdinur mabdinur requested review from genesor and removed request for a team February 9, 2026 15:52
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4923a1255a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Copy link
Collaborator

@nccatoni nccatoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (@DataDog/system-tests-core) but you should get a review from someone familiar the rust weblog

@mabdinur mabdinur enabled auto-merge (squash) February 11, 2026 15:42
@mabdinur mabdinur merged commit faaf162 into main Feb 11, 2026
436 checks passed
@mabdinur mabdinur deleted the munir/add-rust-parametric-endpoints branch February 11, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants