Skip to content

update node.js heap readme #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IlyasShabi merged 1 commit into from
Apr 3, 2026
+1 −10
Merged

update node.js heap readme #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions scenarios/node_heap/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,8 @@ Both functions are called once per iteration in a timed loop, creating equal **n

**Objects Profile**: Should count allocation instances
- Theoretically: 50% `a` / 50% `b` (equal number of calls)
- Actually measured: 33% `a` / 66% `b` (biased toward larger objects)
- Measured: Matches expectations

**Space Profile**: Should count memory usage
- Expected: 33% `a` / 66% `b` (proportional to allocation sizes)
- Measured: Matches expectations

## Open Questions

The objects profile shows bias toward larger allocations (66% vs 50% expected), suggesting the Node.js heap profiler may be:
- Sampling based on allocation size rather than allocation count
- Using size-weighted sampling for performance reasons
- Exhibiting V8 engine optimization effects on string allocation

**TODO**: Clarify with the Node.js profiler team how sampling works and why there's bias toward larger objects in the objects profile.
Loading