Skip to content

Use dd-sts instead of vault because it is more robust#406

Merged
xlamorlette-datadog merged 3 commits into
masterfrom
xlamorlette/more-robust-api-key-retrieval
Jun 25, 2026
Merged

Use dd-sts instead of vault because it is more robust#406
xlamorlette-datadog merged 3 commits into
masterfrom
xlamorlette/more-robust-api-key-retrieval

Conversation

@xlamorlette-datadog

@xlamorlette-datadog xlamorlette-datadog commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

The code coverage CI jobs used to fail quite often, as follows (example):

DD_API_KEY=$(vault kv get -field=key kv/k8s/gitlab-runner/nginx-datadog/datadoghq-api-key 2>/dev/null) npx --yes @datadog/datadog-ci@5.18.0 coverage upload --format=lcov .musl-build/coverage.lcov
Failed getting commits to exclude: RequestError: Request failed with status code 401

We now use [dd-sts[(https://datadoghq.atlassian.net/wiki/x/KwTmVwE) instead of vault because it should be much more reliable.

Reference documentation:

@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Jun 24, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 68.51% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c29a57f | Docs | Datadog PR Page | Give us feedback!

@xlamorlette-datadog xlamorlette-datadog force-pushed the xlamorlette/more-robust-api-key-retrieval branch 4 times, most recently from af803cf to 3496b92 Compare June 24, 2026 13:39
@xlamorlette-datadog xlamorlette-datadog force-pushed the xlamorlette/more-robust-api-key-retrieval branch from 3496b92 to 9920c85 Compare June 24, 2026 14:33
@xlamorlette-datadog xlamorlette-datadog marked this pull request as ready for review June 25, 2026 15:07
@xlamorlette-datadog xlamorlette-datadog requested a review from a team as a code owner June 25, 2026 15:07
@xlamorlette-datadog xlamorlette-datadog merged commit 8f8fbf6 into master Jun 25, 2026
190 checks passed
@xlamorlette-datadog xlamorlette-datadog deleted the xlamorlette/more-robust-api-key-retrieval branch June 25, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants