Conversation
Anilm3
had a problem deploying
to
dd-protected-coverage
GitHub Actions
Failure
Dynamic Artifact Size Comparison 📦
Static Artifact Size Comparison 📦
|
Refactored the upload-coverage job into three distinct jobs: - generate-coverage: merges coverage data and creates artifacts - upload-to-codecov: uploads coverage to CodeCov (runs on all branches) - upload-to-datadog: uploads coverage to DataDog (master branch only) This separation allows parallel uploads and restricts DataDog uploads to production deployments. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #487 +/- ##
=======================================
Coverage 84.92% 84.92%
=======================================
Files 190 190
Lines 9203 9203
Branches 4143 4143
=======================================
Hits 7816 7816
Misses 509 509
Partials 878 878
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Replace ddwaf_init/ddwaf_update with ddwaf_builder API - Fix function signatures (add allocator parameters) - Add ddwaf_builder lifecycle documentation - Add note about ddwaf_subcontext thread safety - Remove outdated allocator and diagnostics sections - Fix grammar: "put in other words" -> "or in other words" Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
API reference (docs/c-api/api.md): - Clarify that output_alloc is for result objects in eval functions - Fix critical error: result must be destroyed with output_alloc, not alloc parameter - Improve thread safety description for WAF handles Upgrading guide (docs/upgrading/UPGRADING-v2.0.md): - Use consistent British spelling throughout - "Context Initialization" → "Context Initialisation" - "Preallocated and preinitialised" → "Pre-allocated and pre-initialised" Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
cataphract
reviewed
Jan 21, 2026
Contributor
cataphract
left a comment
cataphract
left a comment
There was a problem hiding this comment.
unrelated, but infer_schema.cpp also needs to be looked at
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
cataphract
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes:
docs/changelog/*docs/upgrading/*docs/allocators.md