-
Notifications
You must be signed in to change notification settings - Fork 21
fix(shared-runtime): guard shutdown() against Tokio TLS destruction #2169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rachelyangdog
wants to merge
3
commits into
main
Choose a base branch
from
rachel.yang/fix-shared-runtime-tls-shutdown-panic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I worry this catches the symptom, but doesn't actually solve the problem, and we're going to play whack-a-mole with global state being destroyed in a non-deterministic order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I originally created this PR to solve this ticket: https://datadoghq.atlassian.net/browse/APMS-19910. I'm not sure what the root fix would be. Do you have any alternatives in mind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why this would only happen on uwsgi. If TLS is destroyed by CPython we should have the same panic on every python app calling shutdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this solution means we are skipping the flush on shutdown and losing data. I think we should be able to start a new current thread runtime to block on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I think we're having the same issue as unbit/uwsgi#859 which explains why it's specific to uwsgi. Maybe we could patch uwsgi to call the python handlers before cleaning up TLS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, I'm on Python ERE this week for SDK so I'll tackle it from the dd-trace-py angle for this 🤔
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without fixing it in uwsgi specifically (bc this can happen in other setups), I have a draft attempt here: DataDog/dd-trace-py#18853 .If folks think we should wrap uwsgi to fix this I can change approach too.Edit: Actually Claude wasn't able to fully fix this yet, so the approach will change.PR: DataDog/dd-trace-py#18853 will just focus on uwsgi