-
Notifications
You must be signed in to change notification settings - Fork 18
feat: Add FFE_FLAGS remote config product and capability #1532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1532 +/- ##
==========================================
+ Coverage 71.16% 71.25% +0.08%
==========================================
Files 426 426
Lines 69871 69860 -11
==========================================
+ Hits 49724 49777 +53
+ Misses 20147 20083 -64
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2026-02-08 23:58:13 Comparing candidate commit 8d39017 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 56 metrics, 2 unstable metrics. scenario:benching deserializing traces from msgpack to their internal representation
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
4816ee1 to
6217aa7
Compare
- Add FfeFlags variant to RemoteConfigProduct enum - Add "FFE_FLAGS" string mapping in Display and FromStr - Add FfeFlagConfigurationRules = 46 to RemoteConfigCapabilities - Add FfeFlags(Vec<u8>) variant to RemoteConfigData to preserve raw bytes
6217aa7 to
6380964
Compare
…ature flag Gate FFE_FLAGS parsing behind an optional `ffe` feature, consistent with how `live-debugger` works. When enabled, data is parsed into a typed UniversalFlagConfig with proper Debug output; otherwise falls back to raw Vec<u8>.
|
Updated to include the |
|
Sorry for the additional commits after requesting review @bwoebi - should have waited for the Tested locally with both |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
Motivation
Add Feature Flagging and Experimentation (FFE) support to the remote config infrastructure, enabling tracers to subscribe to FFE_FLAGS configurations via the sidecar.
WIP: php tracer changes (DataDog/dd-trace-php#3630)
Changes
FfeFlagsvariant toRemoteConfigProductenum"FFE_FLAGS"string mapping in Display and FromStrFfeFlagConfigurationRules = 46toRemoteConfigCapabilitiesFfeFlags(Vec<u8>)variant toRemoteConfigDatato preserve raw config bytesDecisions
FfeFlags(Vec<u8>)since each tracer handles evaluation with thedatadog-ffecrate directly