[SVLS-8217] feat(trace-stats): Allow custom buffer length #1424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hold on. We are validating if buffer len really impacts undercount. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Right now buffer length is hard coded to 2. This PR allows (and requires) a custom buffer length to be set.
Motivation
When we use this stats concentrator in Lambda extension, we see undercount of 2–5% for
hitsmetric for high volume scenarios. When we changed buffer length from 2 to 1, undercount improved a lot, to 0.1–0.7%. While we are still investigating the cause of undercount, we want to be able to set custom buffer length to remediate the issue to some extent.Additional Notes
Let me know if you prefer to keep the current API and create a new API with the added param.
How to test the change?
Still passing the existing tests.