feat(profiling): Simpler API for profile exporter #1423
+103
−525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1423 +/- ##
==========================================
- Coverage 71.41% 71.27% -0.15%
==========================================
Files 411 411
Lines 66028 65695 -333
==========================================
- Hits 47156 46824 -332
+ Misses 18872 18871 -1
🚀 New features to boost your workflow:
|
gyuheon0h
reviewed
Dec 19, 2025
| #[no_mangle] | ||
| #[named] | ||
| #[must_use] | ||
| pub unsafe extern "C" fn ddog_prof_Exporter_set_timeout( |
Contributor
There was a problem hiding this comment.
This is used in dd-trace-py here. If we choose to remove this, we should clearly document the breaking changes
| .collect() | ||
| } | ||
|
|
||
| /// If successful, builds a `ddog_prof_Exporter_Request` object based on the |
Contributor
There was a problem hiding this comment.
Same as above; used in tracers currently, so clear documentation for breaking changes would be nice
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-apple-darwin
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-apple-darwin
x86_64-unknown-linux-gnu
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Simplifies the FFI API for profiling exporter
Motivation
The API included unnecessary steps, removed them.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Existing tests