DDEV Validate DEP: Always set repo_choice if check_root is true#23649
Draft
ddog-nasirthomas wants to merge 2 commits intomasterfrom
Draft
DDEV Validate DEP: Always set repo_choice if check_root is true#23649ddog-nasirthomas wants to merge 2 commits intomasterfrom
ddog-nasirthomas wants to merge 2 commits intomasterfrom
Conversation
Contributor
Author
|
Didn't add a changelog, but let me know if it's needed |
Contributor
Validation ReportAll 20 validations passed. Show details
|
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
Contributor
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 88a7809 | Docs | Datadog PR Page | Give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When check_root() was true, the repo_choice would never get set for the application config. initialize_root returns immediately when check_root() is true, so it never runs the code that sets config['repo_choice']
This PR makes sure that repo_choice is set even if check_root() is true.
Motivation
Issue found when working through this PR: #23584
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged