Skip to content

DDEV Validate DEP: Always set repo_choice if check_root is true#23649

Draft
ddog-nasirthomas wants to merge 2 commits intomasterfrom
nasir.thomas/ddev-repo-choice-initialization
Draft

DDEV Validate DEP: Always set repo_choice if check_root is true#23649
ddog-nasirthomas wants to merge 2 commits intomasterfrom
nasir.thomas/ddev-repo-choice-initialization

Conversation

@ddog-nasirthomas
Copy link
Copy Markdown
Contributor

@ddog-nasirthomas ddog-nasirthomas commented May 8, 2026

What does this PR do?

When check_root() was true, the repo_choice would never get set for the application config. initialize_root returns immediately when check_root() is true, so it never runs the code that sets config['repo_choice']

This PR makes sure that repo_choice is set even if check_root() is true.

Motivation

Issue found when working through this PR: #23584

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@ddog-nasirthomas
Copy link
Copy Markdown
Contributor Author

Didn't add a changelog, but let me know if it's needed

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 8, 2026

Validation Report

All 20 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and Codecov settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.04%. Comparing base (e529a0b) to head (88a7809).

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-prod-us1-4
Copy link
Copy Markdown
Contributor

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 65.25% (-21.99%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 88a7809 | Docs | Datadog PR Page | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant