Skip to content

Migrate templates from notify_no_data to on_missing_data#23642

Open
zgarciadd wants to merge 1 commit intomasterfrom
zdg/fix_notify_no_data_2
Open

Migrate templates from notify_no_data to on_missing_data#23642
zgarciadd wants to merge 1 commit intomasterfrom
zdg/fix_notify_no_data_2

Conversation

@zgarciadd
Copy link
Copy Markdown

Migrate all recommended monitor templates to use on_missing_data instead of the deprecated notify_no_data. This is a preliminary step to blocking all future usages of notify_no_data.

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 8, 2026

⚠️ Recommendation: Add qa/skip-qa label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 8, 2026

Validation Report

All 20 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and Codecov settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9081a37fb4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

"require_full_window": false,
"notify_no_data": true,
"no_data_timeframe": 120,
"on_missing_data": "show_and_notify_no_data",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve explicit no-data timeframes when migrating

This monitor previously had notify_no_data: true with no_data_timeframe: 120, but on_missing_data uses the query's own time window instead of the old configurable no-data window. Because this query evaluates last_5m, missing Velero data now starts sending NO DATA notifications after about 5 minutes instead of the intended 2 hours; the same migration pattern shortens other alerting delays such as backup_failures (480 minutes) and restore_failures (30 minutes).

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an intended change in behavior, and is what would happen for, e.g., a monitor that was edited and re-saved under the new pattern

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants