Migrate templates from notify_no_data to on_missing_data#23642
Migrate templates from notify_no_data to on_missing_data#23642
Conversation
|
This PR does not modify any files shipped with the agent. To help streamline the release process, please consider adding the |
Validation ReportAll 20 validations passed. Show details
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9081a37fb4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "require_full_window": false, | ||
| "notify_no_data": true, | ||
| "no_data_timeframe": 120, | ||
| "on_missing_data": "show_and_notify_no_data", |
There was a problem hiding this comment.
Preserve explicit no-data timeframes when migrating
This monitor previously had notify_no_data: true with no_data_timeframe: 120, but on_missing_data uses the query's own time window instead of the old configurable no-data window. Because this query evaluates last_5m, missing Velero data now starts sending NO DATA notifications after about 5 minutes instead of the intended 2 hours; the same migration pattern shortens other alerting delays such as backup_failures (480 minutes) and restore_failures (30 minutes).
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This is an intended change in behavior, and is what would happen for, e.g., a monitor that was edited and re-saved under the new pattern
Migrate all recommended monitor templates to use
on_missing_datainstead of the deprecatednotify_no_data. This is a preliminary step to blocking all future usages ofnotify_no_data.