Draft
Conversation
Contributor
Validation ReportAll 20 validations passed. Show details
|
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 5941beb | Docs | Datadog PR Page | Give us feedback! |
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an adaptive readiness gate to the Cilium e2e fixture. After the existing Cilium API limiter warmup (
cilium endpoint list), the fixture now polls Cilium's own metric registry until the raw metric families backing the historically missing Datadog metrics are available.This targets intermittent
Test Agent releasefailures like:Motivation
Kubernetes pod/deployment readiness is not enough for this fixture: Cilium can be
Readywhile event-driven metric families such ascilium_forward_bytes_totalhave not yet appeared. The recent CI path removed incidental warmup delay, making this race easier to hit.Rather than adding a fixed sleep (sensitive to noisy CI runners) or introducing a larger workload/traffic fixture, this waits directly on Cilium's metrics surface using:
Testing
Ran formatting/lint:
Reproduced the failure locally before the fix with warm
--new-envand rc.3 agent. Verified after the fix:Additional local verification:
py3.13-1.11: 3/3 warm attempts passedpy3.13-1.10: 1/1 warm attempt passedpy3.13-1.9: 1/1 warm attempt passed