Revert "feat(datafusion): expose PartitionKeysKind getter on IcebergTableScan (#21)"#25
Merged
toutane merged 1 commit intoJun 16, 2026
Conversation
|
notfilippo
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit
c10a519e4d8801d21aae3e6b9dda8a901fc0d4c8.PartitionKeysKindwas previously used to expose the partitioning strategy derived from a table's partition spec, allowing callers such asdf-executorto configure partitioning at runtime. This approach had two fundamental issues: it bypassed DataFusion's native configuration API, and it attempted to control partitioning logic during execution - too late in the lifecycle, since partitioning is already determined at planning time.To address this, https://github.com/toutane/iceberg-rust/pull/7/changes introduces
IcebergConfig, which implements DataFusion'sConfigExtensioninterface. This replaces the formerPartitionKeysKind-based mechanism with a first-class integration into DataFusion's configuration system.