Skip to content

Revert "feat(datafusion): expose PartitionKeysKind getter on IcebergTableScan (#21)"#25

Merged
toutane merged 1 commit into
branch-0.9from
charlesantoine.leger/revert-partition-keys-kind
Jun 16, 2026
Merged

Revert "feat(datafusion): expose PartitionKeysKind getter on IcebergTableScan (#21)"#25
toutane merged 1 commit into
branch-0.9from
charlesantoine.leger/revert-partition-keys-kind

Conversation

@toutane

@toutane toutane commented Jun 15, 2026

Copy link
Copy Markdown

This reverts commit c10a519e4d8801d21aae3e6b9dda8a901fc0d4c8.

PartitionKeysKind was previously used to expose the partitioning strategy derived from a table's partition spec, allowing callers such as df-executor to configure partitioning at runtime. This approach had two fundamental issues: it bypassed DataFusion's native configuration API, and it attempted to control partitioning logic during execution - too late in the lifecycle, since partitioning is already determined at planning time.

To address this, https://github.com/toutane/iceberg-rust/pull/7/changes introduces IcebergConfig, which implements DataFusion's ConfigExtension interface. This replaces the former PartitionKeysKind-based mechanism with a first-class integration into DataFusion's configuration system.

@datadog-official

Copy link
Copy Markdown

Pipelines

Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

GitHub Actions Security Analysis with zizmor 🌈 | Run zizmor 🌈   View in Datadog   GitHub Actions

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a04643f | Docs | Datadog PR Page | Give us feedback!

@toutane toutane marked this pull request as ready for review June 15, 2026 10:00
@toutane toutane merged commit 5803ca3 into branch-0.9 Jun 16, 2026
17 of 19 checks passed
@toutane toutane deleted the charlesantoine.leger/revert-partition-keys-kind branch June 16, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants