Ensure tuple size matches INSERT column lists.#93
Closed
amw-zero wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmarker is finding cases where our obfuscate_and_normalize procedure leads to un-executable queries. One example of this is that we do not respect the number of columns in an INSERT statement when generating parameter lists.
For example we can produce statements of the form:
Here, the tuple value only has 2 column placeholders, whereas the column list expects 3 columns. This query is un-executable. Interestingly, we had many test cases that encoded this behavior, even though the behavior is wrong.