Skip to content

Update CHANGELOG.md for v0.2.3#102

Merged
ethanperez merged 1 commit into
DataDog:mainfrom
pierreln-dd:pierreln-dd/changelog-v0.2.3
Jul 6, 2026
Merged

Update CHANGELOG.md for v0.2.3#102
ethanperez merged 1 commit into
DataDog:mainfrom
pierreln-dd:pierreln-dd/changelog-v0.2.3

Conversation

@pierreln-dd

Copy link
Copy Markdown
Contributor

Summary

Once #101 merges and this lands, tag v0.2.3 on the resulting commit (matches the v0.2.2 pattern, which was tagged on its CHANGELOG-update commit).

Test plan

  • No code changes — docs only
  • Visual review of the new section against the established CHANGELOG style

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ethanperez ethanperez marked this pull request as ready for review July 6, 2026 15:40
@ethanperez ethanperez requested a review from a team as a code owner July 6, 2026 15:40
@ethanperez ethanperez merged commit 4dc6921 into DataDog:main Jul 6, 2026
6 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 83a136d4cd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CHANGELOG.md
### Bug Fixes

- **Preserve bracket-quoted T-SQL identifiers containing spaces** ([#101](https://github.com/DataDog/go-sqllexer/pull/101))
Bracket-quoted identifiers whose content contains whitespace (e.g. `[Column With Spaces]`) are no longer de-bracketed during normalization. Stripping the brackets produces bare spaces in identifier position, which breaks query structure. Simple identifiers (`[schema]`, `[table]`) and dot-joined multi-part identifiers (`[schema].[table]`) are unaffected and continue to be de-bracketed as before. A secondary fix suppresses the spurious space that the normalizer was inserting between a dot-suffixed token and the bracket-quoted identifier that follows it (e.g. `t. [Col]` → `t.[Col]`).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Base this release note on the fix commit

If v0.2.3 is tagged on this commit, this entry documents a fix that is not in the tree: #101 is not an ancestor of da7aa04, and running this commit still normalizes SELECT t.[Column With Spaces] ... to SELECT t. Column With Spaces .... That would publish a release note saying bracket-quoted identifiers are preserved while users of the tagged release still receive the broken normalization, so this changelog update needs to land on top of the actual fix before tagging.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants