Mark sender thread as fork safe for Puma#315
Open
joshuay03 wants to merge 1 commit intoDataDog:masterfrom
Open
Mark sender thread as fork safe for Puma#315joshuay03 wants to merge 1 commit intoDataDog:masterfrom
joshuay03 wants to merge 1 commit intoDataDog:masterfrom
Conversation
joshuay03
force-pushed
the
mark-sender-thread-as-fork-safe
branch
from
2371e4a to
c70dfad
Compare
nightpool
reviewed
Sep 23, 2025
joshuay03
force-pushed
the
mark-sender-thread-as-fork-safe
branch
from
c70dfad to
f672101
Compare
marcotc
approved these changes
Jan 6, 2026
| # start background thread | ||
| @sender_thread = @thread_class.new(&method(:send_loop)) | ||
| @sender_thread.name = "Statsd Sender" unless Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.3') | ||
| # advise multi-threaded app servers to ignore this thread for the purposes of fork safety warnings |
Member
There was a problem hiding this comment.
Can you add a link to Puma, so we know who's reading this variable?
Something like: https://github.com/puma/puma/blob/5937d8953a154d69cab13887cc361eef9d7df2a4/lib/puma/cluster.rb#L374
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're in the process of enabling Puma's
preload_app!config at @buildkite. When auditing threads spawned during boot, Puma flagged this gem's sender thread as potentially notforksafe. However, based on the documentation for this gem and the implementation ofDatadog::Statsd::Sender#add, the sender thread appearsforksafe to me.This PR adds a
:fork_safethread variable that Puma uses to exclude threads from its safety reporting, so that anyone else auditing their threads this way won't see false positives from this gem.Refs: