Adds DisposeAsync to IDogStatsd Interface for Tracer Usage #224
+199
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Exposes
DisposeAsync()on the publicIDogStatsdinterface, allowing callers to await disposal and avoid sync-over-async patterns.Changes
IDogStatsdnow hasDisposeAsync()DogStatsdServiceimplements itMotivation
With
DisposeAsync(), callers can now doawait dogstatsd.DisposeAsync();instead of blocking withdogstatsd.Dispose();.Testing
DisposeAsync_CanBeCalledMultipleTimes- verifies concurrent dispose calls don't deadlockDisposeAsync_Completes_WithInFlightMetrics- verifies disposal completes even with ongoing metric trafficManual benchmark
CompareSyncVsAsync_UnderStarvation(run with[Explicit]test) shows ~3x faster disposal under thread pool pressure(mostly added to showcase a difference).