DORA Metrics - Change failure detection, follow-ups#34444
Open
api-clients-generation-pipeline[bot] wants to merge 1 commit intomasterfrom
Open
DORA Metrics - Change failure detection, follow-ups#34444api-clients-generation-pipeline[bot] wants to merge 1 commit intomasterfrom
api-clients-generation-pipeline[bot] wants to merge 1 commit intomasterfrom
Conversation
api-clients-generation-pipeline
bot
requested a review
from a team
as a code owner
janine-c
requested changes
Feb 6, 2026
Contributor
janine-c
left a comment
janine-c
left a comment
There was a problem hiding this comment.
Hey there, would it be possible to fix the line breaks I flagged? Seems like some automation is seeing line breaks that are meant to be ignored in the source yaml file and putting line breaks into inappropriate places in the corresponding json file.
| }, | ||
| "PatchDORADeployment": { | ||
| "description": "Use this API endpoint to patch a deployment event.", | ||
| "description": "Update a deployment's change failure status. Use this to mark a deployment as a change\nfailure or back to stable. You can optionally include remediation details to enable\nfailed deployment recovery time calculation.", |
Contributor
There was a problem hiding this comment.
This seems to be interpreting line breaks in the source yaml file as line breaks that need to appear to users. This shouldn't be the case.
| "CreateDORAFailure": { | ||
| "description": "Use this API endpoint to provide failure data.\n\nThis is necessary for:\n- Change Failure Rate\n- Time to Restore", | ||
| "summary": "Send a failure event", | ||
| "description": "Use this API endpoint to provide incident data for DORA Metrics.\nNote that change failure rate and failed deployment recovery time are computed from\nchange failures detected on deployments,\nnot from incident events sent through this endpoint.\nTracking incidents gives a side-by-side view of how failed deployments translate\ninto real-world incidents, including their severity and frequency.", |
Contributor
There was a problem hiding this comment.
More inappropriate line breaks.
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/5026
branch
from
96ec15a to
17fa9ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See DataDog/datadog-api-spec#5026 Test branch datadog-api-spec/test/teddy.gesbert/change_failure_follow_up