Skip to content

[WIP] Use internal, atomic configuration lookup Array#5953

Draft
marcotc wants to merge 1 commit into
masterfrom
marcotc/safer-resolve
Draft

[WIP] Use internal, atomic configuration lookup Array#5953
marcotc wants to merge 1 commit into
masterfrom
marcotc/safer-resolve

Conversation

@marcotc

@marcotc marcotc commented Jun 24, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Motivation:

Change log entry

Additional Notes:

How to test the change?

@dd-octo-sts

dd-octo-sts Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

👋 Hey @marcotc, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2026-06-24 22:37:54 UTC

@dd-octo-sts dd-octo-sts Bot added integrations Involves tracing integrations tracing labels Jun 24, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Typing analysis

Note: Ignored files are excluded from the next sections.

Untyped methods

This PR introduces 1 untyped method, and clears 1 partially typed method.

Untyped methods (+1-0)Introduced:
sig/datadog/tracing/contrib/configuration/resolvers/pattern_resolver.rbs:7
└── def resolve: (untyped value) -> untyped
Partially typed methods (+0-1)Cleared:
sig/datadog/tracing/contrib/configuration/resolvers/pattern_resolver.rbs:7
└── def resolve: (untyped value) -> (nil | untyped)

Untyped other declarations

This PR introduces 1 partially typed other declaration. It decreases the percentage of typed other declarations from 82.62% to 82.56% (-0.06%).

Partially typed other declarations (+1-0)Introduced:
sig/datadog/tracing/contrib/configurable.rbs:8
└── @resolver: Contrib::Configuration::Resolver[untyped, untyped, untyped]?

If you believe a method or an attribute is rightfully untyped or partially typed, you can add # untyped:accept on the line before the definition to remove it from the stats.

@datadog-official

datadog-official Bot commented Jun 24, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 90.03% (+0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: eb1b4e6 | Docs | Datadog PR Page | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrations Involves tracing integrations tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant