Update comment on crash workaround#5895
Conversation
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: c005325 | Docs | Datadog PR Page | Give us feedback! |
BenchmarksBenchmark execution time: 2026-06-15 18:22:24 Comparing candidate commit c005325 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 1 unstable metrics.
|
| # The access `tbl->capa` segfaults because `tbl` is an invalid pointer (https://github.com/ruby/ruby/blob/76cca827ab52a/id_table.c#L132), | ||
| # which comes from an invalid method call-cache table, `RCLASS_CC_TBL(klass)`, | ||
| # retrieved in `cached_callable_method_entry` (https://github.com/ruby/ruby/blob/76cca827ab52a/vm_method.c#L1430-L1433). |
There was a problem hiding this comment.
Minor: I've seen a few variants of the crash stack in https://github.com/DataDog/ruby-guild/issues/242 and in the 4.0.1 report I linked above so I'm not sure if these claims are correct. I'd maybe just link to 242 and not have them here, but I'll leave it up to you to decide :)
Update in-code comment as follow up to #5890, addressing @ivoanjo's feedback.
The comment expands a bit more on where the crash happens and what's involved at the crash site, as well as ensure the links accurately point to the relevant sites.
Change log entry
No.