Skip to content

Update comment on crash workaround#5895

Open
marcotc wants to merge 2 commits into
masterfrom
marcotc/update-comments
Open

Update comment on crash workaround#5895
marcotc wants to merge 2 commits into
masterfrom
marcotc/update-comments

Conversation

@marcotc

@marcotc marcotc commented Jun 12, 2026

Copy link
Copy Markdown
Member

Update in-code comment as follow up to #5890, addressing @ivoanjo's feedback.

The comment expands a bit more on where the crash happens and what's involved at the crash site, as well as ensure the links accurately point to the relevant sites.

Change log entry

No.

@marcotc marcotc requested review from a team as code owners June 12, 2026 20:08
@marcotc marcotc requested review from mabdinur and wantsui June 12, 2026 20:08
@marcotc marcotc self-assigned this Jun 12, 2026
@marcotc marcotc requested a review from ivoanjo June 12, 2026 20:08
@dd-octo-sts dd-octo-sts Bot added integrations Involves tracing integrations tracing labels Jun 12, 2026
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Jun 12, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 89.87% (-0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c005325 | Docs | Datadog PR Page | Give us feedback!

Comment thread lib/datadog/tracing/contrib/configuration/resolver.rb Outdated
@marcotc marcotc requested a review from ivoanjo June 15, 2026 17:58
@pr-commenter

pr-commenter Bot commented Jun 15, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-06-15 18:22:24

Comparing candidate commit c005325 in PR branch marcotc/update-comments with baseline commit 2b5ffb5 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 1 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@ivoanjo ivoanjo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Comment on lines +106 to +108
# The access `tbl->capa` segfaults because `tbl` is an invalid pointer (https://github.com/ruby/ruby/blob/76cca827ab52a/id_table.c#L132),
# which comes from an invalid method call-cache table, `RCLASS_CC_TBL(klass)`,
# retrieved in `cached_callable_method_entry` (https://github.com/ruby/ruby/blob/76cca827ab52a/vm_method.c#L1430-L1433).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: I've seen a few variants of the crash stack in https://github.com/DataDog/ruby-guild/issues/242 and in the 4.0.1 report I linked above so I'm not sure if these claims are correct. I'd maybe just link to 242 and not have them here, but I'll leave it up to you to decide :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrations Involves tracing integrations tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants