Skip to content

[IGNORE] 🪞 #5365 - Feat/make partial flush configurable with env var#5372

Closed
p-datadog wants to merge 3 commits intomasterfrom
community-pr-5365
Closed

[IGNORE] 🪞 #5365 - Feat/make partial flush configurable with env var#5372
p-datadog wants to merge 3 commits intomasterfrom
community-pr-5365

Conversation

@p-datadog
Copy link
Copy Markdown
Member

This PR mirrors the changes from the original community contribution to enable CI testing with maintainer privileges.

Original PR: #5365
Original Author: @jbdelpech
Original Branch: jbdelpech/dd-trace-rb:feat/make-partial-flush-configurable-with-env-var
Mirror Type: exact mirror (preserves original commits and signatures)

Closes #5365


This is an automated mirror created to run CI checks. See tooling/mirror-community-pull-request.sh for details.

@p-datadog p-datadog added core Involves Datadog core libraries community Was opened by a community member tracing labels Feb 17, 2026
@p-datadog p-datadog requested a review from a team as a code owner February 17, 2026 00:09
@p-datadog p-datadog added core Involves Datadog core libraries community Was opened by a community member tracing labels Feb 17, 2026
@p-datadog p-datadog requested review from a team as code owners February 17, 2026 00:09
@p-datadog p-datadog requested a review from vpellan February 17, 2026 00:09
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 17, 2026

👋 Hey @p-datadog, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2026-02-17 01:01:21 UTC

@datadog-official

This comment has been minimized.

Comment thread supported-configurations.json Outdated
],
"DD_TRACE_PARTIAL_FLUSH_MIN_SPANS": [
{
"version": "A",
Copy link
Copy Markdown
Member Author

@p-datadog p-datadog Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-rb/-/jobs/1430353583 says:


Error: There are validation errors:
Existing Configuration Versions:
- DD_TRACE_PARTIAL_FLUSH_MIN_SPANS matches versions C

  • 
    

I checked java and they use version B and value of 1000, python uses 300 with no version given. I take it version needs to be set to C here?

https://feature-parity.us1.prod.dog/configurations?viewType=configurations&configSearch=DD_TRACE_PARTIAL_FLUSH_MIN_SPANS is not specifying values for any of the versions and none of the data is clickable.
2026-02-16_19-31-10

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup we can set this to version C (or we can set the default to 300 to align with python 😆 🥺)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the default would be a breaking change, so yes we should set it to version C

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Feb 17, 2026

Benchmarks

Benchmark execution time: 2026-02-17 00:39:53

Comparing candidate commit e68e2b1 in PR branch community-pr-5365 with baseline commit d943b02 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics.

scenario:tracing - Tracing.log_correlation

  • 🟥 throughput [-10424.724op/s; -10134.978op/s] or [-9.581%; -9.315%]

@p-datadog p-datadog changed the title 🪞 5365 - Feat/make partial flush configurable with env var [IGNORE] 🪞 #5365 - Feat/make partial flush configurable with env var Feb 17, 2026
Comment thread supported-configurations.json Outdated
],
"DD_TRACE_PARTIAL_FLUSH_MIN_SPANS": [
{
"version": "A",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup we can set this to version C (or we can set the default to 300 to align with python 😆 🥺)

@p-datadog p-datadog closed this Mar 4, 2026
@p-datadog p-datadog deleted the community-pr-5365 branch March 4, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Was opened by a community member core Involves Datadog core libraries tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants