[IGNORE] 🪞 #5365 - Feat/make partial flush configurable with env var#5372
[IGNORE] 🪞 #5365 - Feat/make partial flush configurable with env var#5372
Conversation
|
👋 Hey @p-datadog, please fill "Change log entry" section in the pull request description. If changes need to be present in CHANGELOG.md you can state it this way **Change log entry**
Yes. A brief summary to be placed into the CHANGELOG.md(possible answers Yes/Yep/Yeah) Or you can opt out like that **Change log entry**
None.(possible answers No/Nope/None) Visited at: 2026-02-17 01:01:21 UTC |
This comment has been minimized.
This comment has been minimized.
| ], | ||
| "DD_TRACE_PARTIAL_FLUSH_MIN_SPANS": [ | ||
| { | ||
| "version": "A", |
There was a problem hiding this comment.
https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-rb/-/jobs/1430353583 says:
Error: There are validation errors:
Existing Configuration Versions:
- DD_TRACE_PARTIAL_FLUSH_MIN_SPANS matches versions C
I checked java and they use version B and value of 1000, python uses 300 with no version given. I take it version needs to be set to C here?
https://feature-parity.us1.prod.dog/configurations?viewType=configurations&configSearch=DD_TRACE_PARTIAL_FLUSH_MIN_SPANS is not specifying values for any of the versions and none of the data is clickable.

There was a problem hiding this comment.
Yup we can set this to version C (or we can set the default to 300 to align with python 😆 🥺)
There was a problem hiding this comment.
Changing the default would be a breaking change, so yes we should set it to version C
BenchmarksBenchmark execution time: 2026-02-17 00:39:53 Comparing candidate commit e68e2b1 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics. scenario:tracing - Tracing.log_correlation
|
| ], | ||
| "DD_TRACE_PARTIAL_FLUSH_MIN_SPANS": [ | ||
| { | ||
| "version": "A", |
There was a problem hiding this comment.
Yup we can set this to version C (or we can set the default to 300 to align with python 😆 🥺)
e68e2b1 to
ff42f59
Compare
This PR mirrors the changes from the original community contribution to enable CI testing with maintainer privileges.
Original PR: #5365
Original Author: @jbdelpech
Original Branch: jbdelpech/dd-trace-rb:feat/make-partial-flush-configurable-with-env-var
Mirror Type: exact mirror (preserves original commits and signatures)
Closes #5365
This is an automated mirror created to run CI checks. See tooling/mirror-community-pull-request.sh for details.