Conversation
p-datadog
left a comment
There was a problem hiding this comment.
Looking at our appraisals, ruby 4.0 specifies grape < 2.3 (I find it weird that most recent ruby has a requirement of an old grape) and the other MRIs have no grape version constraint. Should we distribute < 1.2, <2.3, 2.3 and 3.0 / 3.1 grape versions throughout the various ruby versions?
p-datadog
left a comment
There was a problem hiding this comment.
Looking at our appraisals, ruby 4.0 specifies grape < 2.3 (I find it weird that most recent ruby has a requirement of an old grape) and the other MRIs have no grape version constraint. Should we distribute < 1.2, <2.3, 2.3 and 3.0 / 3.1 grape versions throughout the various ruby versions?
|
Hello! Thanks for your contribution! We're looking at merging this PR and once it's done, we'll merge this one too |
|
I believe this fixes #5359 |
Co-authored-by: Sergey Fedorov <oni.strech@gmail.com>
What does this PR do?
Grape 3.1.0 introduced a change that breaks fetching the api name from the instance. The change had removed the
attr_readeronbasefor an API instance, resulting in an error when using this version of Grape with datadog.Motivation:
Above error prevented expected service names and values to show up on the dashboard.
Change log entry
Additional Notes:
How to test the change?
I was able to monkey-patch our service in the meantime and I'm see the expected values in the dashboard.