-
Notifications
You must be signed in to change notification settings - Fork 470
chore(profiling): improve typing in memalloc.py
#15500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(profiling): improve typing in memalloc.py
#15500
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 218 ± 4 ms. The average import time from base is: 220 ± 3 ms. The import time difference between this PR and base is: -1.8 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
memalloc.py
56c8412 to
1dd21ff
Compare
Performance SLOsComparing candidate kowalski/chore-profiling-improve-typing-in-memalloc-py (edbe47a) with baseline main (b93a092) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.399µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.6% Memory: ✅ 40.136MB (SLO: <41.500MB -3.3%) vs baseline: +4.5% ✅ add_inplace_aspectTime: ✅ 0.406µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.2% Memory: ✅ 40.318MB (SLO: <41.500MB -2.8%) vs baseline: +5.0% ✅ add_inplace_noaspectTime: ✅ 0.318µs (SLO: <10.000µs 📉 -96.8%) vs baseline: -0.8% Memory: ✅ 40.200MB (SLO: <41.500MB -3.1%) vs baseline: +4.8% ✅ add_noaspectTime: ✅ 0.275µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -0.6% Memory: ✅ 40.287MB (SLO: <41.500MB -2.9%) vs baseline: +5.1% ✅ bytearray_aspectTime: ✅ 1.362µs (SLO: <10.000µs 📉 -86.4%) vs baseline: +1.9% Memory: ✅ 40.139MB (SLO: <41.500MB -3.3%) vs baseline: +4.4% ✅ bytearray_extend_aspectTime: ✅ 1.502µs (SLO: <10.000µs 📉 -85.0%) vs baseline: -0.4% Memory: ✅ 40.476MB (SLO: <41.500MB -2.5%) vs baseline: +5.5% ✅ bytearray_extend_noaspectTime: ✅ 0.615µs (SLO: <10.000µs 📉 -93.9%) vs baseline: ~same Memory: ✅ 40.160MB (SLO: <41.500MB -3.2%) vs baseline: +4.1% ✅ bytearray_noaspectTime: ✅ 0.481µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -0.7% Memory: ✅ 40.120MB (SLO: <41.500MB -3.3%) vs baseline: +4.5% ✅ bytes_aspectTime: ✅ 1.315µs (SLO: <10.000µs 📉 -86.8%) vs baseline: +2.5% Memory: ✅ 40.334MB (SLO: <41.500MB -2.8%) vs baseline: +5.2% ✅ bytes_noaspectTime: ✅ 0.496µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.9% Memory: ✅ 40.338MB (SLO: <41.500MB -2.8%) vs baseline: +4.6% ✅ bytesio_aspectTime: ✅ 1.345µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +1.3% Memory: ✅ 40.299MB (SLO: <41.500MB -2.9%) vs baseline: +4.8% ✅ bytesio_noaspectTime: ✅ 0.495µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.5% Memory: ✅ 40.299MB (SLO: <41.500MB -2.9%) vs baseline: +4.6% ✅ capitalize_aspectTime: ✅ 0.734µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.6% Memory: ✅ 40.218MB (SLO: <41.500MB -3.1%) vs baseline: +4.7% ✅ capitalize_noaspectTime: ✅ 0.438µs (SLO: <10.000µs 📉 -95.6%) vs baseline: +0.4% Memory: ✅ 40.179MB (SLO: <41.500MB -3.2%) vs baseline: +4.7% ✅ casefold_aspectTime: ✅ 0.734µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -1.0% Memory: ✅ 40.198MB (SLO: <41.500MB -3.1%) vs baseline: +4.9% ✅ casefold_noaspectTime: ✅ 0.367µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.5% Memory: ✅ 40.119MB (SLO: <41.500MB -3.3%) vs baseline: +4.1% ✅ decode_aspectTime: ✅ 0.724µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +0.2% Memory: ✅ 40.082MB (SLO: <41.500MB -3.4%) vs baseline: +4.1% ✅ decode_noaspectTime: ✅ 0.415µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -1.1% Memory: ✅ 40.318MB (SLO: <41.500MB -2.8%) vs baseline: +4.7% ✅ encode_aspectTime: ✅ 0.712µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +0.6% Memory: ✅ 40.219MB (SLO: <41.500MB -3.1%) vs baseline: +4.4% ✅ encode_noaspectTime: ✅ 0.397µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.5% Memory: ✅ 40.158MB (SLO: <41.500MB -3.2%) vs baseline: +3.8% ✅ format_aspectTime: ✅ 3.401µs (SLO: <10.000µs 📉 -66.0%) vs baseline: -1.6% Memory: ✅ 40.263MB (SLO: <41.500MB -3.0%) vs baseline: +4.6% ✅ format_map_aspectTime: ✅ 3.510µs (SLO: <10.000µs 📉 -64.9%) vs baseline: -2.1% Memory: ✅ 40.119MB (SLO: <41.500MB -3.3%) vs baseline: +4.4% ✅ format_map_noaspectTime: ✅ 0.778µs (SLO: <10.000µs 📉 -92.2%) vs baseline: +0.3% Memory: ✅ 40.278MB (SLO: <41.500MB -2.9%) vs baseline: +5.3% ✅ format_noaspectTime: ✅ 0.601µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +1.0% Memory: ✅ 40.119MB (SLO: <41.500MB -3.3%) vs baseline: +4.1% ✅ index_aspectTime: ✅ 0.358µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +0.9% Memory: ✅ 40.175MB (SLO: <41.500MB -3.2%) vs baseline: +4.6% ✅ index_noaspectTime: ✅ 0.278µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +0.2% Memory: ✅ 40.159MB (SLO: <41.500MB -3.2%) vs baseline: +4.5% ✅ join_aspectTime: ✅ 1.339µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +1.7% Memory: ✅ 40.215MB (SLO: <41.500MB -3.1%) vs baseline: +4.7% ✅ join_noaspectTime: ✅ 0.492µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.5% Memory: ✅ 40.062MB (SLO: <41.500MB -3.5%) vs baseline: +4.3% ✅ ljust_aspectTime: ✅ 2.942µs (SLO: <20.000µs 📉 -85.3%) vs baseline: 📈 +13.9% Memory: ✅ 40.136MB (SLO: <41.500MB -3.3%) vs baseline: +4.1% ✅ ljust_noaspectTime: ✅ 0.402µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.3% Memory: ✅ 40.120MB (SLO: <41.500MB -3.3%) vs baseline: +4.0% ✅ lower_aspectTime: ✅ 2.311µs (SLO: <10.000µs 📉 -76.9%) vs baseline: +3.0% Memory: ✅ 40.295MB (SLO: <41.500MB -2.9%) vs baseline: +4.8% ✅ lower_noaspectTime: ✅ 0.369µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +1.1% Memory: ✅ 40.099MB (SLO: <41.500MB -3.4%) vs baseline: +4.3% ✅ lstrip_aspectTime: ✅ 2.252µs (SLO: <20.000µs 📉 -88.7%) vs baseline: +0.1% Memory: ✅ 40.106MB (SLO: <41.500MB -3.4%) vs baseline: +4.3% ✅ lstrip_noaspectTime: ✅ 0.387µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +2.2% Memory: ✅ 40.198MB (SLO: <41.500MB -3.1%) vs baseline: +3.9% ✅ modulo_aspectTime: ✅ 1.047µs (SLO: <10.000µs 📉 -89.5%) vs baseline: +5.0% Memory: ✅ 40.378MB (SLO: <41.500MB -2.7%) vs baseline: +5.0% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.538µs (SLO: <10.000µs 📉 -84.6%) vs baseline: -0.7% Memory: ✅ 40.103MB (SLO: <41.500MB -3.4%) vs baseline: +4.5% ✅ modulo_aspect_for_bytesTime: ✅ 0.970µs (SLO: <10.000µs 📉 -90.3%) vs baseline: -1.2% Memory: ✅ 40.292MB (SLO: <41.500MB -2.9%) vs baseline: +5.0% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.236µs (SLO: <10.000µs 📉 -87.6%) vs baseline: +1.3% Memory: ✅ 40.221MB (SLO: <41.500MB -3.1%) vs baseline: +4.5% ✅ modulo_noaspectTime: ✅ 0.632µs (SLO: <10.000µs 📉 -93.7%) vs baseline: +0.4% Memory: ✅ 40.298MB (SLO: <41.500MB -2.9%) vs baseline: +4.3% ✅ replace_aspectTime: ✅ 4.939µs (SLO: <10.000µs 📉 -50.6%) vs baseline: +0.8% Memory: ✅ 40.143MB (SLO: <41.500MB -3.3%) vs baseline: +4.2% ✅ replace_noaspectTime: ✅ 0.458µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +0.2% Memory: ✅ 40.119MB (SLO: <41.500MB -3.3%) vs baseline: +3.9% ✅ repr_aspectTime: ✅ 0.911µs (SLO: <10.000µs 📉 -90.9%) vs baseline: +0.9% Memory: ✅ 40.198MB (SLO: <41.500MB -3.1%) vs baseline: +4.7% ✅ repr_noaspectTime: ✅ 0.411µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.9% Memory: ✅ 40.106MB (SLO: <41.500MB -3.4%) vs baseline: +4.4% ✅ rstrip_aspectTime: ✅ 1.952µs (SLO: <20.000µs 📉 -90.2%) vs baseline: +0.4% Memory: ✅ 40.224MB (SLO: <41.500MB -3.1%) vs baseline: +4.7% ✅ rstrip_noaspectTime: ✅ 0.381µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.9% Memory: ✅ 40.218MB (SLO: <41.500MB -3.1%) vs baseline: +4.0% ✅ slice_aspectTime: ✅ 0.494µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.1% Memory: ✅ 40.235MB (SLO: <41.500MB -3.0%) vs baseline: +5.0% ✅ slice_noaspectTime: ✅ 0.447µs (SLO: <10.000µs 📉 -95.5%) vs baseline: -0.6% Memory: ✅ 40.180MB (SLO: <41.500MB -3.2%) vs baseline: +4.1% ✅ stringio_aspectTime: ✅ 1.549µs (SLO: <10.000µs 📉 -84.5%) vs baseline: +0.7% Memory: ✅ 40.199MB (SLO: <41.500MB -3.1%) vs baseline: +4.5% ✅ stringio_noaspectTime: ✅ 0.714µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -0.9% Memory: ✅ 40.200MB (SLO: <41.500MB -3.1%) vs baseline: +4.4% ✅ strip_aspectTime: ✅ 2.244µs (SLO: <20.000µs 📉 -88.8%) vs baseline: +1.3% Memory: ✅ 40.154MB (SLO: <41.500MB -3.2%) vs baseline: +4.5% ✅ strip_noaspectTime: ✅ 0.386µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +0.3% Memory: ✅ 40.277MB (SLO: <41.500MB -2.9%) vs baseline: +4.3% ✅ swapcase_aspectTime: ✅ 2.515µs (SLO: <10.000µs 📉 -74.9%) vs baseline: +3.0% Memory: ✅ 40.142MB (SLO: <41.500MB -3.3%) vs baseline: +4.6% ✅ swapcase_noaspectTime: ✅ 0.537µs (SLO: <10.000µs 📉 -94.6%) vs baseline: -0.6% Memory: ✅ 40.178MB (SLO: <41.500MB -3.2%) vs baseline: +4.2% ✅ title_aspectTime: ✅ 2.432µs (SLO: <10.000µs 📉 -75.7%) vs baseline: +2.5% Memory: ✅ 40.235MB (SLO: <41.500MB -3.0%) vs baseline: +4.3% ✅ title_noaspectTime: ✅ 0.502µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.7% Memory: ✅ 40.120MB (SLO: <41.500MB -3.3%) vs baseline: +3.9% ✅ translate_aspectTime: ✅ 3.299µs (SLO: <10.000µs 📉 -67.0%) vs baseline: -0.4% Memory: ✅ 40.222MB (SLO: <41.500MB -3.1%) vs baseline: +4.7% ✅ translate_noaspectTime: ✅ 1.039µs (SLO: <10.000µs 📉 -89.6%) vs baseline: ~same Memory: ✅ 40.241MB (SLO: <41.500MB -3.0%) vs baseline: +4.9% ✅ upper_aspectTime: ✅ 2.325µs (SLO: <10.000µs 📉 -76.7%) vs baseline: +3.5% Memory: ✅ 40.136MB (SLO: <41.500MB -3.3%) vs baseline: +4.4% ✅ upper_noaspectTime: ✅ 0.369µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.7% Memory: ✅ 40.198MB (SLO: <41.500MB -3.1%) vs baseline: +4.4% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.198µs (SLO: <10.000µs 📉 -48.0%) vs baseline: 📈 +25.0% Memory: ✅ 40.344MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.1% ✅ ospathbasename_noaspectTime: ✅ 1.081µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -0.3% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +5.0% ✅ ospathjoin_aspectTime: ✅ 6.188µs (SLO: <10.000µs 📉 -38.1%) vs baseline: +1.1% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.0% ✅ ospathjoin_noaspectTime: ✅ 2.290µs (SLO: <10.000µs 📉 -77.1%) vs baseline: ~same Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.0% ✅ ospathnormcase_aspectTime: ✅ 3.449µs (SLO: <10.000µs 📉 -65.5%) vs baseline: +0.5% Memory: ✅ 40.442MB (SLO: <41.000MB 🟡 -1.4%) vs baseline: +5.5% ✅ ospathnormcase_noaspectTime: ✅ 0.570µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -2.5% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +5.0% ✅ ospathsplit_aspectTime: ✅ 4.794µs (SLO: <10.000µs 📉 -52.1%) vs baseline: +0.3% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +5.0% ✅ ospathsplit_noaspectTime: ✅ 1.593µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -0.5% Memory: ✅ 40.206MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +5.1% ✅ ospathsplitdrive_aspectTime: ✅ 3.675µs (SLO: <10.000µs 📉 -63.3%) vs baseline: ~same Memory: ✅ 40.403MB (SLO: <41.000MB 🟡 -1.5%) vs baseline: +5.4% ✅ ospathsplitdrive_noaspectTime: ✅ 0.703µs (SLO: <10.000µs 📉 -93.0%) vs baseline: ~same Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.8% ✅ ospathsplitext_aspectTime: ✅ 4.544µs (SLO: <10.000µs 📉 -54.6%) vs baseline: +0.2% Memory: ✅ 40.206MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.6% ✅ ospathsplitext_noaspectTime: ✅ 1.402µs (SLO: <10.000µs 📉 -86.0%) vs baseline: +1.1% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.2% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.381µs (SLO: <20.000µs 📉 -83.1%) vs baseline: 📈 +15.8% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.4% ✅ 1-count-metrics-100-timesTime: ✅ 198.996µs (SLO: <220.000µs -9.5%) vs baseline: -1.3% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.4% ✅ 1-distribution-metric-1-timesTime: ✅ 3.203µs (SLO: <20.000µs 📉 -84.0%) vs baseline: -2.4% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.0% ✅ 1-distribution-metrics-100-timesTime: ✅ 212.923µs (SLO: <230.000µs -7.4%) vs baseline: -1.5% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.6% ✅ 1-gauge-metric-1-timesTime: ✅ 2.156µs (SLO: <20.000µs 📉 -89.2%) vs baseline: +1.1% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.7% ✅ 1-gauge-metrics-100-timesTime: ✅ 135.674µs (SLO: <150.000µs -9.6%) vs baseline: ~same Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.2% ✅ 1-rate-metric-1-timesTime: ✅ 3.017µs (SLO: <20.000µs 📉 -84.9%) vs baseline: -0.9% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 213.402µs (SLO: <250.000µs 📉 -14.6%) vs baseline: -1.8% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.8% ✅ 100-count-metrics-100-timesTime: ✅ 20.312ms (SLO: <22.000ms -7.7%) vs baseline: +0.2% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.233ms (SLO: <2.550ms 📉 -12.4%) vs baseline: -0.6% Memory: ✅ 34.741MB (SLO: <35.500MB -2.1%) vs baseline: +4.7% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.404ms (SLO: <1.550ms -9.4%) vs baseline: ~same Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.6% ✅ 100-rate-metrics-100-timesTime: ✅ 2.210ms (SLO: <2.550ms 📉 -13.3%) vs baseline: +0.3% Memory: ✅ 34.741MB (SLO: <35.500MB -2.1%) vs baseline: +4.8% ✅ flush-1-metricTime: ✅ 4.536µs (SLO: <20.000µs 📉 -77.3%) vs baseline: -0.5% Memory: ✅ 35.055MB (SLO: <35.500MB 🟡 -1.3%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 173.038µs (SLO: <250.000µs 📉 -30.8%) vs baseline: -0.9% Memory: ✅ 35.114MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +4.2% ✅ flush-1000-metricsTime: ✅ 2.171ms (SLO: <2.500ms 📉 -13.2%) vs baseline: -0.4% Memory: ✅ 35.940MB (SLO: <36.500MB 🟡 -1.5%) vs baseline: +4.9% 🟡 Near SLO Breach (14 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
1dd21ff to
edbe47a
Compare
Description
https://datadoghq.atlassian.net/browse/PROF-13197
This improves typing in
memalloc.py.