update appsec musl image to use _dl_find_object in glibc#4027
Open
cataphract wants to merge 2 commits into
Open
update appsec musl image to use _dl_find_object in glibc#4027cataphract wants to merge 2 commits into
cataphract wants to merge 2 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Using _dl_find_object is more efficient (less lock contention). But when libunwind is built against musl, it doesn't use this path at runtime.
Also pin the image sha in CI for building purposes so that in the futures the changes in unmerged updates are not automatically propagated once we update the image in datadog/images.
Reviewer checklist