Skip to content

Propagate agent configured timeout to sidecar#4025

Open
bwoebi wants to merge 4 commits into
masterfrom
bob/endpoint-timeouts
Open

Propagate agent configured timeout to sidecar#4025
bwoebi wants to merge 4 commits into
masterfrom
bob/endpoint-timeouts

Conversation

@bwoebi

@bwoebi bwoebi commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

And make two RC tests more resilient to race conditions.

Increase the timeout in tests to avoid genuine timeouts from request-replayer overload to happen.

@bwoebi bwoebi requested review from a team as code owners June 30, 2026 12:37

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7e89be7fe0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ext/sidecar.c Outdated
@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Jun 30, 2026

Copy link
Copy Markdown

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 15 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | ASAN test_c with multiple observers: [8.3]   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-php | ASAN test_c: [8.3, arm64]   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-php | ASAN test_c: [8.5, arm64]   View in Datadog   GitLab

View all 15 failed jobs.

1 Test performance regression detected

tmp/build_extension/tests/ext/pcntl/pcntl_fork_thread_mode_orphan.phpt (Thread mode sidecar: orphaned child process promotes itself to master after parent exits) from php.tmp.build_extension.tests.ext.pcntl — 4.06s (+3.27s, +413%)   View in Datadog

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog auto-retried 1 job - 0 passed on retry View in Datadog

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 54.08% (-0.03%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 408f68e | Docs | Datadog PR Page | Give us feedback!

And make two RC tests more resilient to race conditions
@bwoebi bwoebi force-pushed the bob/endpoint-timeouts branch from 7e89be7 to 92d3d15 Compare June 30, 2026 12:47
@pr-commenter

pr-commenter Bot commented Jun 30, 2026

Copy link
Copy Markdown

Benchmarks [ tracer ]

Benchmark execution time: 2026-07-04 02:06:53

Comparing candidate commit 408f68e in PR branch bob/endpoint-timeouts with baseline commit bffd346 in branch master.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 191 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+82.946ns; +148.254ns] or [+5.648%; +10.096%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟥 execution_time [+30.999ns; +130.001ns] or [+2.053%; +8.608%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟥 execution_time [+40.797ns; +117.803ns] or [+2.749%; +7.939%]

@bwoebi bwoebi force-pushed the bob/endpoint-timeouts branch from b60d6be to 408f68e Compare July 4, 2026 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants