feat(profiling): internal metrics for overhead improvements #3618
+36
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This PR is not against
master, but againstlevi/stack_walk_metricin #3616Description
A few improvements to the CPU time tracking for background threads:
update_background_cpu_time()to just beforeexporter.build()so that profile serialization time is included in the metric for the current exported profile. Note: metadata generation, exporter building, and HTTP request time will still be attributed to the next profile period (left a comment in the code about that as well)ddprof_timethreadbackground_threads_cpu_time_nscounter into two metrics,ddprof_time_cpu_time_nsfor theddprof_timethread andddprof_upload_cpu_time_nsfor theddprof_uploadthreadI did those changes in three separate commits (in the order above).
{ "ddprof_upload_cpu_time_ns": 894625, "libdatadog_version": "1.0.0", "stack_walk_cpu_time_ns": 0, "stack_walk_count": 0, "ddprof_time_cpu_time_ns": 8158083 }vs.
{ "libdatadog_version": "1.0.0", "stack_walk_cpu_time_ns": 0, "stack_walk_count": 0, "background_threads_cpu_time_ns": 28375 }.. on the first profile received.
Reviewer checklist